pmon alarm clear

Bug #1826708 reported by yanxubin on 2019-04-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Low
yanxubin

Bug Description

Title
-----

it's logic error to judge clear alarm in manage_alarm

Brief Description
-----------------
file :pmonHdlr.cpp
function: manage_alarm(process_config_type * ptr, int action)

 if ( action == PMON_CLEAR )
    {
        if ( ptr->alarm_severity != FM_ALARM_SEVERITY_CLEAR )
        {
            ilog ("%s from '%s' to 'clear'\n", ptr->process, alarmUtil_getSev_str(ptr->alarm_severity).c_str());
            pmonAlarm_clear ( ctrl_ptr->my_hostname, PMON_ALARM_ID__PMOND, processInfo );
            ptr->alarm_severity = FM_ALARM_SEVERITY_CLEAR ;
        }
        ptr->failed = false ;
    }

if action is PMON_CLEAR and ptr->alarm_severity is FM_ALARM_SEVERITY_CLEAR, we should call pmonAlarm_clear(),
so change "if ( ptr->alarm_severity != FM_ALARM_SEVERITY_CLEAR )" to ptr->alarm_severity == FM_ALARM_SEVERITY_CLEAR

Severity
--------
Major

yanxubin (yanxubin) on 2019-04-28
Changed in starlingx:
assignee: nobody → yanxubin (yanxubin)
Frank Miller (sensfan22) wrote :

Please use the StarlingX bug reporting template when creating new LPs.
Template is here: https://wiki.openstack.org/wiki/StarlingX/BugTemplate
Process is here: https://wiki.openstack.org/wiki/StarlingX/Defect_Handling_Process

Changed in starlingx:
status: New → Incomplete
Ghada Khalil (gkhalil) wrote :

Not release gating given a reproduction scenario is not provided. Issue appears to be found by code inspection. Would be nice to fix, but not high priority. Please feel free to fix and review the code changes with the fault core (Tao Liu)

tags: added: stx.fault
Changed in starlingx:
importance: Undecided → Low
status: Incomplete → Triaged
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers