Create Volume dialog opens (from image panel in Horizon) but getting error default volume type can not be found

[Wendy Mitchell]

Brief Description
-----------------
Create Volume dialog opens (from image panel in Horizon) but getting error default volume type can not be found

Severity
--------
standard

Steps to Reproduce
------------------
1. As tenant user, navigate to the Images panel
2. Select "Create Volume" to opent the dialog
3. Confirm the volume "Type" setting

Expected Behavior
------------------
Create Volume dialog should open and a default "Type" should be set (so that errors are not popping up)

+Note: Create Volume dialog from the Volumes panel has default Volume Type setting "No volume type"

Actual Behavior
----------------
Creating Volume dialog (from image panel) opens without a default Volume Type resulting in error
Error: Unable to retrieve the default volume type.

Reproducibility
---------------
yes

System Configuration
--------------------
any

Branch/Pull Time/Commit
-----------------------
BUILD_ID="20190421T233001Z"

Timestamp/Logs
--------------
"Default volume type can not be found. (HTTP 404) (Request-ID: req-e9858d29-31c8-4d37-a05e-54710d029332)"

[Frank Miller (sensfan22)]

Marking release gating as horizon functionality is not working.
Assigning to Bruce to identify a prime to implement this change in stx-gui.

[Yan Chen (ychen2u)]

This is not a stx-gui feature, it is in Horizon Stein.
The error will pop-up when click "Create Volume" in the images panel, but if no volume type is selected, the volume can still be created successfully. Same result when we run:
  controller-0:/# openstack volume create --image cirros --size 1 new_volume

[Radomir Dopieralski (deshipu)]

There is no "Create Volume" button on the "Images" view.

[Akihiro Motoki (amotoki)]

I am not sure this is a horizon bug or a configuration issue.

According to my test, cinder assumes the default type should be accessible from anyone.
http://paste.openstack.org/show/751672/

Considering this, I am marking this as Incomplete.

[Akihiro Motoki (amotoki)]

FYI: The similar issue on "Create Volume" in the "Volumes" table was reported as bug 1829527.

[Yan Chen (ychen2u)]

We are using the docker image of horizon and cinder, and we found the following error in the horzion log.

# kubectl -n openstack logs horizon-7869cdd7cb-zbb9z

10.10.10.3 - - [10/Jun/2019:08:39:04 +0000] "GET /api/cinder/tenantabsolutelimits/ HTTP/1.1" 200 264 "http://10.10.10.2:31000/project/images" "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:67.0) Gecko/20100101 Firefox/67.0"
2019-06-10 08:39:04.488873 Not Found: /api/cinder/volumetypes/default/

[Akihiro Motoki (amotoki)]

Based on the feedback from the cinder team, the default volume type is assumed to be public. Considering this, this is not a horizon bug apparently. I will remove horizon from the affected projects.

[Yan Chen (ychen2u)]

See from the log of cinder-api pod:
2019-06-24 02:29:47.321 17 INFO cinder.api.openstack.wsgi [req-c8bd9009-ac01-4463-9010-2b3365cad1ee d9061ace4fc84815aaeb43eb1a672099 6540413aaa6248eaa16e2d0cf15b018b - default default] http://cinder-api.openstack.svc.cluster.local:8776/v3/6540413aaa6248eaa16e2d0cf15b018b/types/default returned with HTTP 404
2019-06-24 02:29:47.321 17 INFO cinder.api.openstack.wsgi [req-c8bd9009-ac01-4463-9010-2b3365cad1ee d9061ace4fc84815aaeb43eb1a672099 6540413aaa6248eaa16e2d0cf15b018b - default default] http://cinder-api.openstack.svc.cluster.local:8776/v3/6540413aaa6248eaa16e2d0cf15b018b/types/default returned with HTTP 404

This default api is missing from cinder side.

[yong hu (yhu6)]

@Yan, after this error happened, can we manually select a volume type?

[Yan Chen (ychen2u)]

@yong, yes, user can still manually select a volume type and create the volume successfully.

[yong hu (yhu6)]

We have a workaround to select the volume type manually, so we don't make this issue gate Stx.2.0.
@Yan, have a try to find out in Cinder community if there is a fix for this issue.
If we have solution from Cinder upstream, we might take it in stx.3.0 or further release.

[Zhang Kunpeng (zhangkunpeng)]

This is not a horizon bug as Akihiro Motoki said. We can run the follow commands to fix this problem.

system helm-override-update --set conf.cinder.DEFAULT.default_volume_type=ceph-store stx-openstack cinder openstack
system application-apply stx-openstack

But I don't know if the "default_volume_type=ceph-store" will work well in all deployments. If true, we should update the cinder chart.

[yong hu (yhu6)]

as @Kunpeng commented, this requires an update upon cinder helm-chart. Monitoring this issue on openstack-helm upstream for a while, and resolving it in stx.3.0 if necessary. So I would like to add stx.3.0 tag.

[Yan Chen (ychen2u)]

Found the upstream fix as below:
https://opendev.org/openstack/openstack-helm/commit/0afa508f068fa308daadf0be8c4ae23e95e7ac58

But this fix should be already in from April, what's the base version of our helm_chart?

[Zhang Kunpeng (zhangkunpeng)]

"BUILD = 20190717T013000Z" has this problem

[Yan Chen (ychen2u)]

I mean the latest openstack-helm already has this default_type fix.
Are we using the latest openstack-helm?
Or we may need to add the default_type as override.

[Zhang Kunpeng (zhangkunpeng)]

I don't know, but helm_chart default_type is "rdb1", will it be overrided without helm plugins of stx-config? If not, I think it is necessary.

[ya.wang (ya.wang)]

I don't known why launchpad not auto update the fix patch's link. Therefore i paste it here manual:
https://review.opendev.org/#/c/672401

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/672401
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=fc2423a5119423bd1fe55a7822d63bab58e783f1
Submitter: Zuul
Branch: master

commit fc2423a5119423bd1fe55a7822d63bab58e783f1
Author: zhangkunpeng <[e-mail]>
Date: Wed Jul 24 11:12:19 2019 +0800

    Make sure to set default_volume_type when only one storage backend

    if there is only one backend, the default_volume_type will not be set.
    Then error "default volume type can not be found" will raise when
    creating volume from image panel in horizon.

    Closes-Bug: 1826259
    Change-Id: Ia9c6d30418b41bc15de7a34bec60b3bdae8324d7
    Signed-off-by: zhangkunpeng <[e-mail]>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.2.0
Review: https://review.opendev.org/675802

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/675802
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=9e599bd80121f4e06de411164e9a2d5726d84a20
Submitter: Zuul
Branch: r/stx.2.0

commit 9e599bd80121f4e06de411164e9a2d5726d84a20
Author: zhangkunpeng <[e-mail]>
Date: Wed Jul 24 11:12:19 2019 +0800

    Make sure to set default_volume_type when only one storage backend

    if there is only one backend, the default_volume_type will not be set.
    Then error "default volume type can not be found" will raise when
    creating volume from image panel in horizon.

    Closes-Bug: 1826259
    Change-Id: Ia9c6d30418b41bc15de7a34bec60b3bdae8324d7
    Signed-off-by: zhangkunpeng <[e-mail]>
    (cherry picked from commit fc2423a5119423bd1fe55a7822d63bab58e783f1)

[Ghada Khalil (gkhalil)]

Given this was cherrypicked to the stx.2.0 release branch, I am changing the release tag from stx.3.0 to stx.2.0