Host with host name longer than 32 bytes does not go online

[Eric MacDonald]

Host with host name longer than 32 bytes does not go online.

Severity: minor

Steps to Reproduce: create hosts with hostnames longer than 32 characters

Expected Behavior: host goes online after installation

Actual Behavior: host stays offline

Reproducibility: Reproducible 100%

System Configuration: Any

Branch/Pull Time/Commit: Any

Last Pass: Never

Timestamp/Logs: N/A

Test Activity: Any

[Ghada Khalil (gkhalil)]

Assigning to Eric as he is already familiar with this issue and is working on a fix.

[Ghada Khalil (gkhalil)]

Marking as release gating; as this is a would-be-nice to fix. Not very high priority.

[Bart Wensley (bartwensley)]

When we increase the maximum supported host length from 32 to something larger, we also need to update sysinv to prevent the addition/modification of hostnames longer than what we support. The user should not be able to add a host with a hostname so long that it causes the system to malfunction.

[Eric MacDonald (rocksolidmtce)]

I have not seen the system malfunction as a result of adding an extra long hostname since sysinv supports 255 byte names. Such extra long names longer than 63 bytes just won't resolve in the kernel and the host won't come online.

I agree that the main stx stream should prevent provisioning hostnames longer than the system supports.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/665969

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665969
Committed: https://git.openstack.org/cgit/starlingx/metal/commit/?id=a4238c2a355899aa4d6d9bcd429a7f8614041416
Submitter: Zuul
Branch: master

commit a4238c2a355899aa4d6d9bcd429a7f8614041416
Author: Eric MacDonald <email address hidden>
Date: Tue Jun 18 08:33:28 2019 -0400

    Add 50 byte hostname support to maintenance

    Hosts with hostnames longer than 31 characters do not
    go online (locked-disabled-online) after installation.

    This update enhances maintenance messaging to support
    up to 50 byte/character hostnames.

    System Install:
    ---------------
    PASS: Verify system install
    PASS: Verify AIO system install (regression)
    PASS: Verify system install with long hostnames, deployment-config.yaml
    PASS: Verify mtcAgent process startup/restart logs
    PASS: Verify hbsAgent process startup/restart logs (active controller)
    PASS: Verify hbsAgent process startup/restart logs (standby controller)
    PASS: Verify hwmond process startup/restart logs
    PASS: Verify guestAgent process startup/restart logs
    PASS: Verify all common maintenance daemons startup/restart logs
    PASS: Verify patch applies and removes cleanly

    PASS: Verify long hostname Add ; inventory distribution
    PASS: Verify short hostname Add ; inventory distribution

    Long Hostname Handling:
    -----------------------
    PASS: Verify host name support for up to 50 and 51 byte hostnames

    Heartbeat Monitoring:
    ---------------------
    PASS: Verify cluster-host interface link down handling.
    PASS: Verify graceful recovery from host reboot.
    PASS: Verify pmond process failure and recovery cycle.

    Maintenance Actions:
    --------------------
    PASS: Verify host install with 50 byte hostname
    PASS: Verify host lock
    PASS: Verify host unlock
    PASS: Verify host reboot
    PASS: Verify host reinstall
    PASS: Verify host delete (no core dump / all daemon logs)
    PASS: Verify host power-off
    PASS: Verify host power-on
    PASS: Verify BMC State Info
    PASS: Verify lock and unlock storage node
    PASS: Controller Swact over and Back
    PASS: Verify thresholded heartbeat failure handling
    PASS: Verify node locked flag file
    PASS: Verify no core dumps during testiong

    Hardware Monitor:
    -----------------
    PASS: Verify BMC Provisioning/Reprovisioning/Deprovisioning
    PASS: Verify Inventory Add/Delete/Modify
    PASS: Verify Sensor Model and Monitoring
    PASS: Verify Sensor Model Relearn
    PASS: Verify Alarming and Logs
    PASS: Verify Sensor Action, Interval modification
    PASS: Verify Critical Sensor Action handling (ignore, log, alarm, reset, power cycle)

    Guest Agent:
    ------------
    PASS: Verify inventory add and delete

    Process Monitor:
    ----------------
    PASS: Verify process monitor logs
    PASS: Verify process monitor events into mtcAgent
    PASS: Verify process monitor failure alarming and recovery clear.
    PASS: Verify process monitor regression script (test-pmon.sh -c restart)
    PASS: Verify process monitor regression script (test-pmon.sh -c kill)
 ...