Openstack compute labels assigned to worker nodes by default

[Brent Rowsell]

Brief Description
-----------------
I did not assign the openstack compute labels to a worker node.

Severity
--------
Critical, system not useable for non-openstack worker nodes

Steps to Reproduce
------------------
Install and provision a worker node without assigning the openstack compute labels. Unlock worker nodes

Expected Behavior
------------------
Openstack compute labels were not assigned

Actual Behavior
----------------
Openstack compute labels are assigned

Reproducibility
---------------
100%

System Configuration
--------------------
Standard system

Branch/Pull Time/Commit
-----------------------
19.01
2019-04-05 20:23:11 -0400

Last Pass
---------
Suspect never

Timestamp/Logs
--------------
Problem code is here
sysinv/conductor/kube_app.py

    def _process_node_labels(self, app, op=constants.LABEL_ASSIGN_OP):
        # Node labels are host personality based and are defined in
        # metadata.yaml file in the following format:
        # labels:
        # controller: '<label-key1>=<value>, <label-key2>=<value>, ...'
        # compute: '<label-key1>=<value>, <label-key2>=<value>, ...'

...

# Add the default labels for system app. They must exist for
        # the app manifest to be applied successfully. If the nodes have
        # been assigned these labels manually before, these
        # reassignments are simply ignored.
        if app.system_app:
            controller_labels_set.add(constants.CONTROL_PLANE_LABEL)
            compute_labels_set.add(constants.COMPUTE_NODE_LABEL)
            compute_labels_set.add(constants.OPENVSWITCH_LABEL)
            compute_labels_set.add(constants.SRIOV_LABEL)

Test Activity
-------------
Other

[Ghada Khalil (gkhalil)]

Marking as release gating; should be addressed asap as it prevents the use of a containerized env without openstack.

[Bart Wensley (bartwensley)]

In recent testing I also noticed that I was not able to unlock a worker node without first provisioning a nova-local volume on the worker node. This should not be required for worker nodes that do not have the openstack compute labels and should also be fixed under this bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/652109

[David Sullivan (dsullivanwr)]

Note, Bart's issue should be addressed by https://review.openstack.org/#/c/631541/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/652109
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=aed40b7369e06182c4d4bc59b36344534ccc6b3a
Submitter: Zuul
Branch: master

commit aed40b7369e06182c4d4bc59b36344534ccc6b3a
Author: David Sullivan <email address hidden>
Date: Fri Apr 12 11:56:28 2019 -0400

    Compute labels assigned to worker nodes by default

    We should not be assigning labels to nodes as part of any application
    action. This removes that functionality.

    Change-Id: I0ecf7e7efe061297028c89e2476fcc6db954a7a2
    Closes-Bug: 1823705
    Signed-off-by: David Sullivan <email address hidden>