SM monitoring calico i/f's

[Brent Rowsell]

Brief Description
-----------------
SM is monitoring calico virtual interfaces which is incorrect

Severity
--------
Major

Steps to Reproduce
------------------
Normal system usage

Expected Behavior
------------------
SM should only monitor interfaces that is uses

Actual Behavior
----------------
Seems to be monitoring all interfaces

Reproducibility
---------------
100%

System Configuration
--------------------
All

Branch/Pull Time/Commit
-----------------------
19.01
2019-03-28 20:22:20 -0400

Last Pass
---------
Pre-container

Timestamp/Logs
--------------
2019-04-07T10:50:09.000 controller-0 sm: debug time[746460.436] log<32148> INFO: sm[27014]: sm_failover.c(1214): Interface cali1e4e341876d state changed to 1
2019-04-07T10:50:09.000 controller-0 sm-eru: debug time[746460.436] log<3862> ERROR: sm-eru[27039]: sm_hw.c(255): Failed to get interface state for interface (cali1e4e341876d), error=No such device.
2019-04-07T10:55:02.000 controller-0 sm: debug time[746753.608] log<32149> INFO: sm[27014]: sm_failover.c(1205): Interface cali978029354f7 is down
2019-04-07T10:55:02.000 controller-0 sm: debug time[746753.609] log<32150> INFO: sm[27014]: sm_failover.c(1209): Interface cali978029354f7 is up
2019-04-07T10:55:02.000 controller-0 sm: debug time[746753.609] log<32151> INFO: sm[27014]: sm_failover.c(408): No domain interface is impacted as i/f cali978029354f7 is up.
2019-04-07T10:55:02.000 controller-0 sm: debug time[746753.610] log<32152> INFO: sm[27014]: sm_failover.c(1209): Interface cali978029354f7 is up
2019-04-07T10:55:02.000 controller-0 sm: debug time[746753.610] log<32153> INFO: sm[27014]: sm_failover.c(408): No domain interface is impacted as i/f cali978029354f7 is up.
2019-04-07T10:55:02.000 controller-0 sm: debug time[746753.635] log<32154> INFO: sm[27014]: sm_failover.c(1205): Interface cali914d922703e is down
2019-04-07T10:55:02.000 controller-0 sm: debug time[746753.636] log<32155> INFO: sm[27014]: sm_failover.c(1209): Interface cali914d922703e is up
2019-04-07T10:55:02.000 controller-0 sm: debug time[746753.636] log<32156> INFO: sm[27014]: sm_failover.c(408): No domain interface is impacted as i/f cali914d922703e is up.
2019-04-07T10:55:02.000 controller-0 sm: debug time[746753.637] log<32157> INFO: sm[27014]: sm_failover.c(1209): Interface cali914d922703e is up
2019-04-07T10:55:02.000 controller-0 sm: debug time[746753.637] log<32158> INFO: sm[27014]: sm_failover.c(408): No domain interface is impacted as i/f cali914d922703e is up.
2019-04-07T10:55:11.000 controller-0 sm: debug time[746761.737] log<32159> INFO: sm[27014]: sm_failover.c(1205): Interface cali978029354f7 is down
2019-04-07T10:55:11.000 controller-0 sm: debug time[746761.749] log<32160> ERROR: sm[27014]: sm_hw.c(255): Failed to get interface state for interface (cali978029354f7), error=No such device.

Test Activity
-------------
Developer testing

[Ghada Khalil (gkhalil)]

Marking as release gating; not urgent given there doesn't appear to be a serious system impact. However, this causes noise in the logs.

[Bin Qian (bqian20)]

SM monitors all interfaces, and only process failover on the ones that are configured as OAM, mgmt, or infra networks.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/663705

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/663705
Committed: https://git.openstack.org/cgit/starlingx/ha/commit/?id=4b9ace1ef37e97543a60d8323a776136070c98d9
Submitter: Zuul
Branch: master

commit 4b9ace1ef37e97543a60d8323a776136070c98d9
Author: Bin Qian <email address hidden>
Date: Thu Jun 6 11:40:07 2019 -0400

    Cleanup loggings

    SM receives network interfaces state change on controllers.
    But it should only log state changed of the network interfaces
    that are used by SM.

    Closes-Bug: 1823531

    Change-Id: Iacdeeb8cfbb288b6b5572db606b97c18847950db
    Signed-off-by: Bin Qian <email address hidden>