ipmitool missing in starlingx iso

[Peng Peng]

Brief Description
-----------------
As title

Severity
--------
Major

Steps to Reproduce
------------------
ls /usr/bin/ipmitool

Expected Behaviour
------------------
ipmitool should be exist

Actual Behaviour
----------------
/usr/bin/ipmitool: No such file or directory

Reproducibility
---------------
Reproducible
100%

System Configuration
--------------------
Multi-node system

Branch/Pull Time/Commit
-----------------------
master as of 20190327T013001Z

Timestamp/Logs
--------------

controller-0:~$ ls /usr/bin/ipmitool
ls: cannot access /usr/bin/ipmitool: No such file or directory
controller-0:~$ date
Wed Mar 27 18:01:35 UTC 2019

[Ghada Khalil (gkhalil)]

Marking as release gating; high priority given this prevents BMC access.

It appears that the ipmitool was removed from the iso (as part of a load cleanup activity) because there is no explicit dependency defined for it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/648517

[Al Bailey (albailey1974)]

ipmitool was being implicitly pulled in by these rpms

openstack-ironic-common-9.1.2-0.tis.4.noarch
openstack-nova-compute-16.0.2-1.tis.20.noarch
openstack-ceilometer-ipmi-9.0.1-1.tis.18.noarch

all three were removed from ISO by
https://review.openstack.org/#/q/I4109398df9ff9f5608721f70611b7554fc31eacb

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/648517
Committed: https://git.openstack.org/cgit/openstack/stx-metal/commit/?id=f10b9a51701a434aa6db73cc8e47cfb5714d9750
Submitter: Zuul
Branch: master

commit f10b9a51701a434aa6db73cc8e47cfb5714d9750
Author: Eric MacDonald <email address hidden>
Date: Thu Mar 28 15:30:52 2019 -0400

    Add mtce dependency on ipmitool

    ipmitool was recently found to be missing from the load after
    a rpm cleanup that seemed to remove all dependency on it.

    Maintenance and its Hardware Monitor use the ipmitool
    for power / reset control as well as sensor monitoring.

    This update adds a dependency on ipmitool in the maintenance
    mtcAgent and hwmon rpm build recipe so that it will always
    be included in the load with maintenance.

    Closes-Bug:1821958

    Test Plan:
    PASS: Verify ipmitool in load
    PASS: Verify mtce and hwmon rpm dependency on ipmitool
    PASS: Verify system install

    Change-Id: I958a2365f6df7bdbf942bc57c1aa17ee2ae6a73d
    Signed-off-by: Eric MacDonald <email address hidden>