build-stx-images.sh builds agains out of date base image

[Scott Little]

Title
-----
build-stx-images.sh builds agains out od date base image

Brief Description
-----------------
build-stx-images.sh failed on cgts4. It appears that it was building against a base image from December. build-stx-images.sh needs to do a pull against the base image to ensure it is up to date.

Severity
--------
Provide the severity of the defect.
Critical: build failure, failure to build current software.

Steps to Reproduce
------------------
On a machine with a pre-existing but dated copy of docker.io/starlingx/stx-centos:dev-latest...run the command

build-stx-images.sh --prefix dev --latest-prefix dev --os centos --release master --version 2019-03-21_20-30-00 --base docker.io/starlingx/stx-centos:dev-latest --wheels ./std/stx-centos-master-wheels.tar --latest

If the base image is old enough, the build of fails. If not, the age if the base image can be seen with ...

docker inspect <image-name>

Expected Behavior
------------------
Build succeeds, and the image has used the current dev-latest base image from cengn.

Actual Behavior
----------------
Build tries to use out of date local copy of starlingx/stx-centos:dev-latest, and fails to build.

Reproducibility
---------------
<Reproducible/Intermittent>
100%

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
2019-03-22

Timestamp/Logs
--------------
build-stx-images.sh --prefix dev --latest-prefix dev --os centos --release master --version 2019-03-21_20-30-00 --base docker.io/starlingx/stx-centos:dev-latest --wheels ./std/build-wheels-centos-master/stx-centos-master-wheels.tar
...
--> Processing Conflict: 10:qemu-img-ev-3.0.0-0.tis.97.x86_64 conflicts qemu-img-rhel
--> Processing Conflict: 10:qemu-img-1.5.3-160.el7_6.1.x86_64 conflicts qemu-img-rhev
Removing qemu-img.x86_64 10:1.5.3-160.el7_6.1 - u due to obsoletes from installed 10:qemu-img-ev-3.0.0-0.tis.97.x86_64
--> Restarting Dependency Resolution with new changes.
--> Running transaction check
---> Package openssh-server.x86_64 0:7.4p1-16.el7 will be installed
--> Processing Dependency: openssh = 7.4p1-16.el7 for package: openssh-server-7.4p1-16.el7.x86_64
---> Package qemu-img.x86_64 10:1.5.3-160.el7_6.1 will be installed
--> Finished Dependency Resolution
Error: qemu-img conflicts with 10:qemu-img-ev-3.0.0-0.tis.97.x86_64
Error: qemu-img-ev conflicts with 10:qemu-img-1.5.3-160.el7_6.1.x86_64
Error: Package: openssh-server-7.4p1-16.el7.x86_64 (base)
           Requires: openssh = 7.4p1-16.el7
           Installed: openssh-7.4p1-16.el7_4.tis.10.x86_64 (@stx-local-build)
               openssh = 7.4p1-16.el7_4.tis.10
           Available: openssh-7.4p1-16.el7.x86_64 (base)
               openssh = 7.4p1-16.el7
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest
The command '/bin/sh -c /opt/loci/scripts/install.sh' returned a non-zero code: 1

[Erich Cordoba (ericho)]

Does this means that this `docker pull` doesn't work to get the latest image in the registry?

https://opendev.org/starlingx/root/src/branch/master/build-tools/build-docker-images/build-stx-images.sh#L566

[Scott Little (slittle1)]

Don added the line you sight was added to address this issue.

https://opendev.org/starlingx/root/commit/492b5b218d0a01263714d94ded931b03fa608477

He should have had an additional "Closes-Bug: 1821624"

[Erich Cordoba (ericho)]

Then we can close this bug :)

[Erich Cordoba (ericho)]

This bug was fixed in this commit but with an incorrect bug ID: https://opendev.org/starlingx/root/commit/492b5b218d0a01263714d94ded931b03fa608477