Simplex - can’t start VM when deploying in AMD environment

[hutianhao27]

Title
-----
Simplex - Can’t start VM when deploying in AMD environment.

Brief Description
--------
when deploying Simplex in AMD environment, it’s failing to start VM.

Severity
--------
Critical on Simplex in AMD environment: can’t start VM

Steps to Reproduce
------------------
Follow up https://docs.starlingx.io/installation_guide/latest/simplex.html, it’s failing to start VM for every installation attempt in AMD environment.

Expected Behavior
------------------
Start VM successfully.

Actual Behavior
----------------
Can’t start VM in AMD environment.

Reproducibility
---------------
100% on simplex in AMD environment

System Configuration
--------------------
Simplex AMD BareMetal

Branch/Pull Time/Commit
-----------------------
CENGN Master ISO: http://mirror.starlingx.cengn.ca/mirror/starlingx/master/centos/latest_build/outputs/iso/

Timestamp/Logs
--------------
Here is a console output:

Formatting '/var/lib/libvirt/images/simplex-controller-0-0.img', fmt=qcow2 size=644245094400 encryption=off cluster_size=65536 lazy_refcounts=off refcount_bits=16
Formatting '/var/lib/libvirt/images/simplex-controller-0-1.img', fmt=qcow2 size=214748364800 encryption=off cluster_size=65536 lazy_refcounts=off refcount_bits=16
Formatting '/var/lib/libvirt/images/simplex-controller-0-2.img', fmt=qcow2 size=214748364800 encryption=off cluster_size=65536 lazy_refcounts=off refcount_bits=16
Domain simplex-controller-0 defined from vms/simplex-controller-0.xml

error: Failed to start domain simplex-controller-0
error: unsupported configuration: guest and host CPU are not compatible: Host CPU does not provide required features: vmx

[Ghada Khalil (gkhalil)]

The current stx community members do not have access to AMD hardware to investigate. If this support is important to you, you'll need to investigate and propose the required code changes via gerrit. The community can then review and merge the changes if accepted.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/647668

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/647668
Committed: https://git.openstack.org/cgit/openstack/stx-tools/commit/?id=436ca8c17a0528d1c7dcb5280ba4de96948d085e
Submitter: Zuul
Branch: master

commit 436ca8c17a0528d1c7dcb5280ba4de96948d085e
Author: hutianhao <[e-mail]>
Date: Tue Mar 26 06:59:16 2019 +0000

    Modify controller_allinone.xml for deploying simplex in AMD environment

    Change cpu feature policy for vmx to start VM successfully in AMD environment.

    Closes-Bug: 1821572

    Change-Id: I9dfaf4cc05efa86e76e3ef53351b88c07529e114
    Signed-off-by: hutianhao <[e-mail]>

[Ghada Khalil (gkhalil)]

Added stx.2.0 label since this is the release that includes the fix