Distributed cloud: Patch Orchestration does not work

[Tao Liu]

Distributed cloud: Patch Orchestration does not work

Brief Description
-----------------
The dcmanager on the system controller failed to create patch strategy for sub-clouds.
This problem is caused by some keyword argument name mismatch in the vim interfaces that used by the dcmanager. The argument names that have compute reference have been changed to worker on the vim side while the dcmanager still uses the old names.

Severity
--------
Critical

Steps to Reproduce
------------------
Upload and apply one patch, and then start Patch Orchestration Using the CLI
dcmanager patch-strategy create
dcmanager patch-strategy apply

Observe the progress:
dcmanager strategy-step list

Expected Behavior
------------------
The strategy created for subcloud1

Actual Behavior
----------------
Strategy creation failed for subcloud1:
dcmanager strategy-step list
+------------------+-------+----------+----------------------------------------+----------------------------+----------------------------+
| cloud | stage | state | details | started_at | finished_at |
+------------------+-------+----------+----------------------------------------+----------------------------+----------------------------+
| SystemController | 1 | complete | | 2019-03-20 19:05:02.865266 | 2019-03-20 19:05:22.927324 |
| subcloud1 | 2 | failed | Strategy creation failed for subcloud1 | 2019-03-20 19:05:32.937920 | 2019-03-20 19:06:05.474074 |
+------------------+-------+----------+----------------------------------------+----------------------------+----------------------------+

Reproducibility
---------------
 100%

System Configuration
--------------------
Multi-node system, IPv4

Branch/Pull Time/Commit
-----------------------
master, 2019-03-18_20-18-00

Timestamp/Logs
--------------
2019-03-20 19:06:02.974 32705 INFO dcmanager.manager.sw_update_manager [-] Applying patch strategy
2019-03-20 19:06:02.983 32705 INFO dcmanager.manager.sw_update_manager [-] Creating patch strategy for subcloud1
2019-03-20 19:06:05.473 32705 WARNING dcmanager.manager.sw_update_manager [-] Strategy creation failed for subcloud1
2019-03-20 19:06:12.986 32705 INFO dcmanager.manager.sw_update_manager [-] Applying patch strategy
2019-03-20 19:06:12.995 32705 INFO dcmanager.manager.sw_update_manager [-] Strategy application has failed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/645011

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/645013

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/645011
Committed: https://git.openstack.org/cgit/openstack/stx-distcloud/commit/?id=ae73fe3469ca44e1c37b6d6ca115d628678fae05
Submitter: Zuul
Branch: master

commit ae73fe3469ca44e1c37b6d6ca115d628678fae05
Author: Tao Liu <email address hidden>
Date: Wed Mar 20 17:10:35 2019 -0400

    Distributed cloud: Fix Patch Orchestration

    The dcmanager failed to create patch strategy for sub-clouds.
    This problem is caused by keyword argument name mismatch in the
    vim interfaces that used by the dcmanager.
    The argument names that have compute reference have been
    changed to worker on the vim side while the dcmanager
    still uses the old names.

    This update changes all compute references to worker in
    dcmanager including the data model.

    Closes-Bug:1821081

    Change-Id: I8cb2dea286e7f91d9b34cc13c57d40de018f3a9f
    Signed-off-by: Tao Liu <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/645013
Committed: https://git.openstack.org/cgit/openstack/stx-distcloud-client/commit/?id=0203b97ef85c42a3e3dbd745e60d7f3eaa6904ad
Submitter: Zuul
Branch: master

commit 0203b97ef85c42a3e3dbd745e60d7f3eaa6904ad
Author: Tao Liu <email address hidden>
Date: Wed Mar 20 17:29:00 2019 -0400

    Distributed cloud: Fix Patch Orchestration

    The dcmanager failed to create patch strategy for sub-clouds.
    This problem is caused by keyword argument name mismatch in the
    vim interfaces that used by the dcmanager.
    The argument names that have compute reference have been
    changed to worker on the vim side while the dcmanager
    still uses the old names.

    This update changes all compute references to worker in
    dcmanagerclient.

    Closes-Bug:1821081
    Depends-On: https://review.openstack.org/#/c/645011/

    Change-Id: I04488623ef601422352f77372259e4a514c11681
    Signed-off-by: Tao Liu <email address hidden>

[Ghada Khalil (gkhalil)]

Marking as release gating; related to Distributed Cloud patching