config out-of-date is not cleared on standby controller after disabling ntp

[Yang Liu]

Brief Description
-----------------
After disabling ntp via system ntp-modify and lock/unlock host, standby controller config out-of-date status is not cleared.

Severity
--------
Major

Steps to Reproduce
------------------
- system ntp-modify --enable=false
- lock/unlock standby controller

Expected Behavior
------------------
Config out-of-date status should be cleared after lock/unlock in fm alarm-list and system host-show

Actual Behavior
----------------
standby controller stuck with Config out-of-date status

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Multi-node system

Branch/Pull Time/Commit
-----------------------
master as of 2019-03-18
This is the first time the TC is run after container cut-over. This was working with the non-container deployment

Timestamp/Logs
--------------
2019-03-19T19:26:08.000 controller-1 -sh: info HISTORY: PID=121924 UID=1875 system ntp-modify --enable=false
2019-03-19T19:34:30.000 controller-1 -sh: info HISTORY: PID=121924 UID=1875 system host-unlock controller-0

[Ghada Khalil (gkhalil)]

Marking as release gating; appears to be an issue introduced in the containerized environment. Was not seen on non-container builds.

[Lin Shuicheng (shuicheng)]

Hi Yang, I try to reproduce the issue with latest code today, I find both controller node will be in out-of-date status after execute "system ntp-modify --enable=false", and alarm will not be cleared in both node. While in your description, it seems only the standby controller node will have the out-of-date alarm.
Is the status the same as you?
Thanks.

[Yang Liu (yliu12)]

Hi Shuicheng, you need to lock/unlock the out-of-date host to clear the alarm against it.

[Lin Shuicheng (shuicheng)]

Hi Yang,
I reproduced the issue previous, and cannot reproduce it with latest code. After Lock/Unlock controller-1, the alarm could be cleared.
Could you help have a try with latest image for this issue?
Thanks.

[Yang Liu (yliu12)]

This issue is not seen on a storage system with 20190408T233001Z load.

[Lin Shuicheng (shuicheng)]

Mark as Fix-Released, since issue cannot reproduce with latest image.

[Anujeyan Manokeran (anujeyan)]

Another launch pad was open which is same as this . Looks like this issue is not fully fixed in load 20190410T013000Z

https://bugs.launchpad.net/starlingx/+bug/1824814

[Anujeyan Manokeran (anujeyan)]

Verified in load "2019-06-13