Patching: sw-patch install-local returns 0 when request fails due to lighttpd failure

[mhg]

Brief Description
-----------------
A problem was found during retest another issue.
After restore the system reported a patching failed on controller-0.
The root cause was the changes introduced by fix to the other issue, and just exposed an otherwise hidden issue that:
sw-patch install-local returns 0 when request fails due to lighttpd failure

Note: the issue was originally found on 2018-06-19 and was asked to re-report in launchpad.

Severity
--------
Major

Steps to Reproduce
------------------
Install the first node of a system, and before running config_controller:
1 upload patches
2 apply patches
3 install the patches using CLI:
sudo sw-patch install-local

Expected Behavior
------------------
- the CLI completed without any errors
- patches were installed

Actual Behavior
----------------
- the CLI failed

Reproducibility
---------------
Reproducible
System Configuration
--------------------
Multi-node system

Branch/Pull Time/Commit
-----------------------
master as of build-date-time
2018-06-13_22-03-13

Timestamp/Logs
--------------
20180618 .20:32:00

[Ghada Khalil (gkhalil)]

Marking as release gating; issue with the patching software

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/642528
Committed: https://git.openstack.org/cgit/openstack/stx-update/commit/?id=ef0398bb7f5bb01023c610f0fed65025ccca6b7e
Submitter: Zuul
Branch: master

commit ef0398bb7f5bb01023c610f0fed65025ccca6b7e
Author: Don Penney <email address hidden>
Date: Mon Mar 11 13:28:33 2019 -0400

    Add failure checks to patching init script

    The sw-patch init script is called by the 'sw-patch install-local'
    command with a restart option to trigger the patch-agent to
    install patches, as there is no communications between the
    patch-agent and patch-controller at this point. However, the
    init script was not checking for failures reported by the
    patch-agent when it tries to install patches.

    In the case of #1819496, the lighttpd server was not running,
    due to a temporary config change at the time. As a result, the
    patch-agent was unable to communicate with the patching repo,
    and failed to install the patch. Because the init script was
    not checking for failures, the failure went unreported to the user.

    This update adds checks to the sw-patch init script, in order
    to report the failure back to the user.

    Change-Id: Id8d69bef3a5c6c2f81d56f4b26752d084f9a7ff2
    Closes-Bug: 1819496
    Signed-off-by: Don Penney <email address hidden>