restarting sysinv-agent raise error

[cheng li]

Brief Description
-----------------
`systemctl restart sysinv-agent` raises error

Severity
--------
Minor

Steps to Reproduce
------------------
1. tailf /var/log/sysinv.log
2. systemctl restart sysinv-agent

Expected Behavior
------------------
No error log during sysinv-agent restart

Actual Behavior
----------------
Find error log during sysinv-agent restart

Reproducibility
---------------
100%

System Configuration
--------------------
AIO simplex deployment
Containerized

Branch/Pull Time/Commit
-----------------------
ISO built on Mar 5th

Timestamp/Logs
--------------
https://pastebin.com/2jM6Hmh4

[Ghada Khalil (gkhalil)]

Why are you calling "systemctl restart sysinv-agent"? The sysinv-agent is managed by SM. Attempting to restart it directly can result in errors.

[cheng li (chengli3)]

When I debug sysinv code, I need to restart sysinv services(sysinv-api, sysinv-conductor, sysinv-agent) after changing sysinv code.

For sysinv-api service and sysinv-conductor service, I kill the process directly, then the service is restarted.

For sysinv-agent, I restart the service with systemctl restart.

[Brent Rowsell (brent-rowsell)]

This process is not managed by systemd so you cannot use systemctl to restart it.
If you need to restart is use sudo sm-restart service sysinv-inv to restart the api and sudo sm-restart service sysinv-conductor to restart the conductor.

[Ghada Khalil (gkhalil)]

Assigned to Brent since he provided the resolution/closure for this report.

[cheng li (chengli3)]

Brent, thanks for providing the command to restart sysinv-api and sysinv-conductor.
So what about sysinv-agent? I tried sudo sm-restart service sysinv-agent, it says no such service.
```
controller-0:~$ sudo sm-restart service sysinv-agent
Given service (sysinv-agent) does not exist.
```

I do see sysinv-agent is managed by systemd.
And the error log comes with 'systemctl restart sysinv-agent'

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/653677
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=d8ba7d68e908f8caba418b8d4993e2035dd78a48
Submitter: Zuul
Branch: master

commit d8ba7d68e908f8caba418b8d4993e2035dd78a48
Author: chengli3 <email address hidden>
Date: Thu Apr 18 15:02:46 2019 +0800

    Remove neutron host operations in sysinv conductor

    Everytime sysinv-agent is started/restarted, it call sysinv-conductor
    rpc subfunctions_update_by_ihost. sysinv-conductor tries to list/create
    neutron host, but seems neutron host feature is removed(because the
    python-neutronclient doesn't support these apis anymore, i.e.
    list_hosts, create_hosts). As a result, subfunctions_update_by_ihost
    raise exception.

    This patch is to remove neutron host operations in
    subfunctions_update_by_ihost.

    Closes-bug: #1819400

    Change-Id: Ia4f8871547460b7fa186e18966008efdc088b784
    Signed-off-by: chengli3 <email address hidden>

[Ghada Khalil (gkhalil)]

Added stx.2.0 label since this is the release that includes the fix