tss2 fails to download causing an incomplete mirror

[Marcela Rosales]

Title
-----
tss2 fails to download causing an incomplete mirror

Brief Description
-----------------
The intention of this commit https://review.openstack.org/#/c/632820/
was to standardize the download procedure for all tarballs.
Unfortunately, the URL merged does not always work, causing a download
failure for this tarball and an incomplete mirror.

Severity
--------
Major

Steps to Reproduce
------------------
Developer guide for image creation

Expected Behavior
------------------
Download the mirror complete

Actual Behavior
----------------
The mirror is missing tss2 tarball

Reproducibility
---------------
Intermittent

System Configuration
--------------------
Build environment

Branch/Pull Time/Commit
-----------------------

Timestamp/Logs
--------------

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/637574
Committed: https://git.openstack.org/cgit/openstack/stx-tools/commit/?id=a044f794c4662760f1ca89d0f8d3bec20a49c4e5
Submitter: Zuul
Branch: master

commit a044f794c4662760f1ca89d0f8d3bec20a49c4e5
Author: Marcela Rosales <email address hidden>
Date: Mon Feb 18 16:03:43 2019 +0000

    Revert "Change download mechanism for tss2 (git clone to wget)"

    This reverts commit 40a9622d7716e60a28807724ce5eece22f0e1c0c.

    The URL for tss2 is not always working and this causes an
    incomplete mirror in a clean environment.

    Closes-bug:1816813
    Change-Id: I9c8fa64e1f0f9154dd45a67088fdc27f4b8f8313
    Signed-off-by: Marcela Rosales <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos76
Review: https://review.openstack.org/638278

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/stein
Review: https://review.openstack.org/638476

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/638476
Committed: https://git.openstack.org/cgit/openstack/stx-tools/commit/?id=3e8e923846b1e1574a72d4e19755460c069aa84e
Submitter: Zuul
Branch: f/stein

commit a044f794c4662760f1ca89d0f8d3bec20a49c4e5
Author: Marcela Rosales <email address hidden>
Date: Mon Feb 18 16:03:43 2019 +0000

    Revert "Change download mechanism for tss2 (git clone to wget)"

    This reverts commit 40a9622d7716e60a28807724ce5eece22f0e1c0c.

    The URL for tss2 is not always working and this causes an
    incomplete mirror in a clean environment.

    Closes-bug:1816813
    Change-Id: I9c8fa64e1f0f9154dd45a67088fdc27f4b8f8313
    Signed-off-by: Marcela Rosales <email address hidden>

commit 12ca05299dea13c62952048e50a17d1ca354e328
Author: Erich Cordoba <email address hidden>
Date: Tue Feb 19 10:14:25 2019 -0600

    Move docker creation and deletion to tb.sh

    A makefile was used only for creation and clean up of the docker
    image for building. In this process, all the environment variables
    were sourced and included into the Makefile. However this can fail
    on systems that has functions and cause a failing makefile.

    Trying to fixing this issue I realize that this Makefile ain't needed,
    as all the logic for docker management is under `tb.sh`, therefore makes
    sense to remove this Makefile and use this script for the entire process.

    Story: 2002560

    Change-Id: I2795593521a5d16dc2033861946fd09c2270424e
    Signed-off-by: Erich Cordoba <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/638278
Committed: https://git.openstack.org/cgit/openstack/stx-tools/commit/?id=3bc38cead7846802c83541a8103849c784a87282
Submitter: Zuul
Branch: f/centos76

commit a044f794c4662760f1ca89d0f8d3bec20a49c4e5
Author: Marcela Rosales <email address hidden>
Date: Mon Feb 18 16:03:43 2019 +0000

    Revert "Change download mechanism for tss2 (git clone to wget)"

    This reverts commit 40a9622d7716e60a28807724ce5eece22f0e1c0c.

    The URL for tss2 is not always working and this causes an
    incomplete mirror in a clean environment.

    Closes-bug:1816813
    Change-Id: I9c8fa64e1f0f9154dd45a67088fdc27f4b8f8313
    Signed-off-by: Marcela Rosales <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/640473

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/640473
Committed: https://git.openstack.org/cgit/openstack/stx-tools/commit/?id=d0429f790d0313ed6bcd3fd84d873e7d7c4a7dd8
Submitter: Zuul
Branch: master

commit a044f794c4662760f1ca89d0f8d3bec20a49c4e5
Author: Marcela Rosales <email address hidden>
Date: Mon Feb 18 16:03:43 2019 +0000

    Revert "Change download mechanism for tss2 (git clone to wget)"

    This reverts commit 40a9622d7716e60a28807724ce5eece22f0e1c0c.

    The URL for tss2 is not always working and this causes an
    incomplete mirror in a clean environment.

    Closes-bug:1816813
    Change-Id: I9c8fa64e1f0f9154dd45a67088fdc27f4b8f8313
    Signed-off-by: Marcela Rosales <email address hidden>

commit 12ca05299dea13c62952048e50a17d1ca354e328
Author: Erich Cordoba <email address hidden>
Date: Tue Feb 19 10:14:25 2019 -0600

    Move docker creation and deletion to tb.sh

    A makefile was used only for creation and clean up of the docker
    image for building. In this process, all the environment variables
    were sourced and included into the Makefile. However this can fail
    on systems that has functions and cause a failing makefile.

    Trying to fixing this issue I realize that this Makefile ain't needed,
    as all the logic for docker management is under `tb.sh`, therefore makes
    sense to remove this Makefile and use this script for the entire process.

    Story: 2002560

    Change-Id: I2795593521a5d16dc2033861946fd09c2270424e
    Signed-off-by: Erich Cordoba <email address hidden>