Re-install host failed after the http port is changed

[Tao Liu]

Title
-----
Re-install host failed after http port is changed

Brief Description
-----------------
After changing the http port, reinstall a host will fail, and it requires delete/add the host to recover.

Severity
--------
Critical: System/Feature is not usable after the defect

Steps to Reproduce
------------------
system service-parameter-modify http config http_port=8099
system service-parameter-apply http
Wait for the alarm to be cleared on all hosts
system host-lock compute-1
System host-reinstall compute-1

Expected Behavior
------------------
Compute-1 should be reinstalled successfully

Actual Behavior
----------------
Compute-1 failed to reinstall

Reproducibility
---------------
100%

System Configuration
--------------------
Two controller + Two compute

Branch/Pull Time/Commit
-----------------------
master, Feb 11 11:30

Timestamp/Logs
--------------
system host-list
+----+--------------+-------------+----------------+-------------+--------------+
| id | hostname | personality | administrative | operational | availability |
+----+--------------+-------------+----------------+-------------+--------------+
| 1 | controller-0 | controller | unlocked | enabled | available |
| 2 | controller-1 | controller | unlocked | enabled | available |
| 3 | compute-0 | worker | unlocked | enabled | available |
| 7 | compute-1 | worker | locked | disabled | offline |
+----+--------------+-------------+----------------+-------------+--------------+

[Tao Liu (tliu88)]

This issue is due to reinstall does not update the pxeboot config file until a unlock action is performed; consequently the boot parameter is not updated with the new port number.

The proposed fix is to set the configure_required flag when the host is reinstalled.

[Ghada Khalil (gkhalil)]

Marking as release gating; issue reported by feature designer

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/636344

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/636344
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=a6d71ae50ec1b24a1edf9863b49597f6507e4426
Submitter: Zuul
Branch: master

commit a6d71ae50ec1b24a1edf9863b49597f6507e4426
Author: Tao Liu <email address hidden>
Date: Tue Feb 12 09:08:07 2019 -0500

    Re-install host failed after http port changed

    After changing the http port, reinstall a host will fail,
    and it requires delete/add the host to recover.

    This problem is due to reinstall does not update the
    pxeboot config file until a unlock action is performed;
    consequently the boot parameter is not updated with
    the new port number.

    This update sets the configure_required flag when the
    host is reinstalled.

    Closes-Bug: 1815495

    Change-Id: Ie4f8206f93370ce4555bce9d53879b784200ba14
    Signed-off-by: Tao Liu <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/stein
Review: https://review.openstack.org/636381

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/636381
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=f610da837a8a612bc09b09b9009fde6a6aeae9a7
Submitter: Zuul
Branch: f/stein

commit a6d71ae50ec1b24a1edf9863b49597f6507e4426
Author: Tao Liu <email address hidden>
Date: Tue Feb 12 09:08:07 2019 -0500

    Re-install host failed after http port changed

    After changing the http port, reinstall a host will fail,
    and it requires delete/add the host to recover.

    This problem is due to reinstall does not update the
    pxeboot config file until a unlock action is performed;
    consequently the boot parameter is not updated with
    the new port number.

    This update sets the configure_required flag when the
    host is reinstalled.

    Closes-Bug: 1815495

    Change-Id: Ie4f8206f93370ce4555bce9d53879b784200ba14
    Signed-off-by: Tao Liu <email address hidden>

commit c34dcbb2dad010a175278f8d544c132995545739
Author: Bin Qian <email address hidden>
Date: Tue Feb 5 09:50:16 2019 -0500

    Configure kubelet.service to be monitored by pmond

    Use puppet manifest to setup the following:
    1. create kubelet service override to turn off systemd
       auto restart
    2. create kubelet pmon conf file to setup pmond
       to monitor kubelet

    Story: 2002843
    Task: 29255

    Depends-On I41206c7ea14d79b5d0cbca945e7a6488eda9b7bb
    Change-Id: I94659dd26b664c643270baa2c013f0910a07bf12
    Signed-off-by: Bin Qian <email address hidden>