devstack failed in stx-fault

[Yi Wang]

Brief Description
 -----------------
After running stack.sh for devstack, the deployment failed in stx-fault

Severity
 --------
 Minor

Steps to Reproduce
 ------------------
1. clone DevStack repo https://git.openstack.org/openstack-dev/devstack
2. replace local.conf with https://wiki.openstack.org/wiki/StarlingX/Devstack/stx-config/localrc
3. ./stack.sh.

Expected Behavior
 ------------------
 stack.sh can end up successfully with stx-fault devstack plugin enabled

Actual Behavior
 ----------------
 the script failed in enabling stx-fault plugin

Reproducibility
 ---------------
 Reproducible (10/10)

System Configuration
--------------------
n/a

Branch/Pull Time/Commit
-----------------------
the latest master code of 2019-01-22

Timestamp/Logs
-----------------------
++/opt/stack/stx-fault/devstack/lib/stx-fault:install_fm_common:240 pushd /opt/stack/stx-fault/fm-common/sources
~/stx-fault/fm-common/sources ~/devstack
++/opt/stack/stx-fault/devstack/lib/stx-fault:install_fm_common:241 make MAJOR=1 MINOR=0
g++ -Wl,-soname,libfmcommon.so.1 -o libfmcommon.so.1.0 -shared fmAPI.o fmFile.o fmLog.o fmMsgServer.o fmMutex.o fmSocket.o fmThread.o fmTime.o fmAlarmUtils.o fmDb.o fmDbUtils.o fmDbAlarm.o fmSnmpUtils.o fmDbEventLog.o fmEventSuppression.o fmConfig.o -lstdc++ -lrt -luuid -lpq -lpthread -lpython2.7
ln -sf libfmcommon.so.1.0 libfmcommon.so.1
ln -sf libfmcommon.so.1.0 libfmcommon.so
g++ -o fmClientCli fm_cli.o -L./ -lfmcommon
++/opt/stack/stx-fault/devstack/lib/stx-fault:install_fm_common:242 sudo python setup.py build
running build
running build_ext
++/opt/stack/stx-fault/devstack/lib/stx-fault:install_fm_common:245 sudo make DEST_DIR=/usr BIN_DIR=/bin LIB_DIR=/lib INC_DIR=/include MAJOR=1 MINOR=0 install_non_bb
make: *** No rule to make target `install_non_bb'. Stop.
+/opt/stack/stx-fault/devstack/lib/stx-fault:install_fm_common:1 exit_trap

[OpenStack Infra (hudson-openstack)]

Change abandoned by Yi Wang (<email address hidden>) on branch: master
Review: https://review.openstack.org/632247
Reason: there is already a patch https://review.openstack.org/#/c/632192/ for this issue. so drop this patch.

[Austin Sun (sunausti)]

https://review.openstack.org/#/c/632192/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/632192
Committed: https://git.openstack.org/cgit/openstack/stx-fault/commit/?id=83023a2d184dec164a52d93c745290bdc8bd0735
Submitter: Zuul
Branch: master

commit 83023a2d184dec164a52d93c745290bdc8bd0735
Author: Sun Austin <email address hidden>
Date: Tue Jan 22 09:09:28 2019 +0800

    change install_non_bb to install target in devstack

    change install_non_bb to install due to
    I431b733030444185cc51a8b5352492926170a4c3 change
    Force to use xenial(nodeset:openstack-single-node-xenial)

    Closes-bug: 1812785

    Change-Id: I61338a79f09d59b1f1e36a4911ecadad4a3453e8
    Signed-off-by: Sun Austin <email address hidden>

[Ghada Khalil (gkhalil)]

Adding stx.2019.05 tag as this fix was merged for that release