system modify command does not accept capitalized True/False
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Fix Released
|
Medium
|
Austin Sun |
Bug Description
Title
-----
system modify command does not accept capitalized True/False
Brief Description
-----------------
Only "true" and "false" are accepted by the 'system modify' command options --https_enabled and --sdn_enabled.
Severity
--------
Minor
Steps to Reproduce
------------------
These example commands:
system modify --https_
system modify --sdn_enabled=False
Where as 'system show' command display "True" or "False"
Expected Behavior
------------------
true/false options should be case insensitive
Actual Behavior
----------------
true/false options are only accepted as "true" and "false".
Reproducibility
---------------
Reproducible
System Configuration
-------
any
Branch/Pull Time/Commit
-------
2019-01-16_20-18-01
starlingx/master
Timestamp/Logs
--------------
# system show | grep "https_
| https_enabled | True |
| sdn_enabled | False |
# system modify --https_enabled False
...
system modify: error: argument -p/--https_enabled: invalid choice: 'False' (choose from 'true', 'false')
# system modify --sdn_enabled=True
...
system modify: error: argument -s/--sdn_enabled: invalid choice: 'True' (choose from 'true', 'false')
Changed in starlingx: | |
assignee: | nobody → Cindy Xie (xxie1) |
tags: | added: six.config |
tags: |
added: stx.config removed: six.config |
Changed in starlingx: | |
importance: | Undecided → Medium |
tags: |
added: stx.2019.05 removed: stx.2019.03 |
Changed in starlingx: | |
assignee: | Cindy Xie (xxie1) → Austin Sun (sunausti) |
tags: |
added: stx.2.0 removed: stx.2019.05 |
Marking as release gating. This is a minor issue, but all sysinv cmds should be aligned and behave similarly (assuming other cmds accept: true/True false/False).
This is also a good learning opportunity for someone ramping up on StarlingX