Python 3 changes for print statement cause breakages

Bug #1808808 reported by Bart Wensley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Austin Sun

Bug Description

Title
-----
Python 3 changes for print statement cause breakages

Brief Description
-----------------
The changes made in https://review.openstack.org/#/c/621512 made some changes for old style prints that avoided newline from this:
print "some string",
to this:
print("some string", end=" ")

The problem is that having a space in the end parameter makes a functional change and adds an extra space to the end of the string. This has already broken backup/restore (see https://bugs.launchpad.net/starlingx/+bug/1808417)

The author of https://review.openstack.org/#/c/621512 needs to go back and remove the space from the end parameter in every case where this was done.

Severity
--------
Provide the severity of the defect.
Critical

Steps to Reproduce
------------------
Backup/restore was broken. I'm not sure what else might be broken.

Expected Behavior
------------------
The change to support python 3 compatible print statements should not introduce any functional changes.

Actual Behavior
----------------
See above.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Any

Branch/Pull Time/Commit
-----------------------
See above

Timestamp/Logs
--------------
Not applicable.

Austin Sun (sunausti)
Changed in starlingx:
assignee: nobody → Austin Sun (sunausti)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-config (master)

Fix proposed to branch: master
Review: https://review.openstack.org/625790

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-config (master)

Reviewed: https://review.openstack.org/625790
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=05ae4ae6b6192e889d1074cd235edc36fd6a50b2
Submitter: Zuul
Branch: master

commit 05ae4ae6b6192e889d1074cd235edc36fd6a50b2
Author: Sun Austin <email address hidden>
Date: Tue Dec 18 10:12:02 2018 +0800

    replace end=' ' with end='' for print to file

    Closes-bug: 1808808

    Change-Id: I5ff170f9cafe754ea21e8a09f91a2be552eadb74
    Signed-off-by: Sun Austin <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
Ghada Khalil (gkhalil) wrote :

Release gating - issue introduced by recent code changes in support of python3

tags: added: stx.2019.03 stx.config stx.python2
Changed in starlingx:
importance: Undecided → Medium
Ken Young (kenyis)
tags: added: stx.2019.05
removed: stx.2019.03
Ken Young (kenyis)
tags: added: stx.2.0
removed: stx.2019.05
Ghada Khalil (gkhalil)
tags: added: stx.python3
removed: stx.python2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.