Unable to compile stx-metal project with -Werror=format-security flag

[Luis Botello]

Title
-----
Unable to compile pingUtil.cpp with -Werror=format-security flag

Brief Description
-----------------
Function pingUtil.cpp can not be compiled if flag -Werror=format-security is set on Makefile.

Severity
--------
Minor: System/Feature is usable but with security issues.

Steps to Reproduce
------------------
Add -Werror=format-security flag into mtce-common/src/common/Makefile

Expected Behavior
------------------
Project compilation should be completed with no issues.

Actual Behavior
----------------
Project can not be compiled if flag is set.

Reproducibility
---------------
100%

System Configuration
--------------------
All compilation environments

Branch/Pull Time/Commit
-----------------------
Master / November 14 2018, Commit: 0d9bb5e

Timestamp/Logs
--------------
pingUtil.cpp:207:74: error: format not a string literal and no format arguments [-Werror=format-security]
   snprintf ( &ping4_tx.msg[0], PING_MESSAGE_LEN, ping_info.message );
                    ^
pingUtil.cpp:207:74: error: format not a string literal and no format arguments [-Werror=format-security]
pingUtil.cpp:229:74: error: format not a string literal and no format arguments [-Werror=format-security]
   snprintf ( &ping6_tx.msg[0], PING_MESSAGE_LEN, ping_info.message );
                    ^
pingUtil.cpp:229:74: error: format not a string literal and no format arguments [-Werror=format-security]

[Luis Botello (lbotell)]

Same issue is also seen on rmonHdlr.cpp, while compiling with -Werror=format-security flag, caused by snprintf function. Adding a file containing whole error information: rmonHdlr.log

[Victor Manuel Rodriguez Bahena (vm-rod25)]

commit 1db3320c3c708089ee9ae9297d91761eed4049a5 (HEAD -> master)
Author: Victor Rodriguez <email address hidden>
Date: Wed Nov 28 08:10:33 2018 -0600

    Try to fix security bug 1803621

    https://bugs.launchpad.net/starlingx/+bug/1803621

    Signed-off-by: Victor Rodriguez <email address hidden>

diff --git a/mtce-common/src/common/pingUtil.cpp b/mtce-common/src/common/pingUtil.cpp
index d8afdc1..24eb664 100644
--- a/mtce-common/src/common/pingUtil.cpp
+++ b/mtce-common/src/common/pingUtil.cpp
@@ -203,8 +203,7 @@ int pingUtil_send ( ping_info_type & ping_info )

         ping4_tx.hdr.un.echo.id = htons(ping_info.identity) ;
         ping4_tx.hdr.un.echo.sequence = htons(ping_info.sequence) ;
-
- snprintf ( &ping4_tx.msg[0], PING_MESSAGE_LEN, ping_info.message );
+ snprintf (&ping4_tx.msg[0],"%s",PING_MESSAGE_LEN, ping_info.message);

         /* checksum should not be converted to htons
          * - will get (wrong icmp cksum ) */

[Ken Young (kenyis)]

These launchpad is really a feature which is covered by the following stories:
1. https://storyboard.openstack.org/#!/story/2004656
2. https://storyboard.openstack.org/#!/story/2004380