pylint failing for stx-config

Bug #1802329 reported by Al Bailey on 2018-11-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
High
Al Bailey

Bug Description

Title
-----
pylint failing in stx-config for controllerconfig

Brief Description
-----------------
yamllint 1.12.1 was released Oct 17, 2018 and seems to have an additional check which
is causing pylint to now fail.

Module controllerconfig.upgrades.controller
E:1405,36: Suspicious argument in str.strip call (bad-str-strip-call)

Need to change:
  hieradata_tmpdir = os.path.join(staging_dir,
                                    constants.HIERADATA_PERMDIR.strip('//'))

to
  hieradata_tmpdir = os.path.join(staging_dir,
                                    constants.HIERADATA_PERMDIR.strip('/'))

Severity
--------
No one can submit code to controllerconfig in stx-config

Steps to Reproduce
------------------
Submit code to stx-config. The zuul check will fail.

Expected Behavior
------------------
pylint should pass

Actual Behavior
----------------
pylint fails

Reproducibility
---------------
Zuul (any time a check or gate is run)

System Configuration
--------------------
Zuul

Branch/Pull Time/Commit
-----------------------
master

Timestamp/Logs
--------------
Module controllerconfig.upgrades.controller
2018-11-08 12:54:34.050111 | ubuntu-xenial | E:1405,36: Suspicious argument in str.strip call (bad-str-strip-call)

Al Bailey (albailey1974) on 2018-11-08
Changed in starlingx:
assignee: nobody → Al Bailey (albailey1974)
Changed in starlingx:
status: New → In Progress
Ghada Khalil (gkhalil) wrote :

High priority as this prevents code from being merged in stx-config

tags: added: stx.2019.03 stx.zuul
Changed in starlingx:
importance: Undecided → High

Reviewed: https://review.openstack.org/616589
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=13088d262b01cc7a2331599875d1e0a622220a20
Submitter: Zuul
Branch: master

commit 13088d262b01cc7a2331599875d1e0a622220a20
Author: Al Bailey <email address hidden>
Date: Thu Nov 8 09:40:32 2018 -0600

    Fix pylint issue exposed by yamllint 1.12.1

    When yamllint 1.12.1 was released Oct 17, 2018 it
    was pickier about the str.strip syntax.

    This change fixes pylint.
    Verified that strip('/') and strip('//') work the same

    Change-Id: I82864134289cdabb642876bc2c867d0a35428b96
    Signed-off-by: Al Bailey <email address hidden>
    Closes-Bug: 1802329

Changed in starlingx:
status: In Progress → Fix Released
Ken Young (kenyis) on 2019-01-18
tags: added: stx.2019.05
removed: stx.2019.03
Ken Young (kenyis) on 2019-04-05
tags: added: stx.2.0
removed: stx.2019.05
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers