Distributed Cloud: pep8 error when operate tox comand

[junboli]

root@ubuntu # tox -e pep8
pep8 create: /home/commit/stx-distcloud/.tox/pep8
pep8 installdeps: hacking<0.11,>=0.10.2
pep8 installed: flake8==2.2.4,hacking==0.10.3,mccabe==0.2.1,pbr==3.1.1,pep8==1.5.7,pyflakes==0.8.1,six==1.10.0
pep8 runtests: PYTHONHASHSEED='3108529466'
pep8 runtests: commands[0] | flake8
./setup_ddt_tests.py:70:19: E901 SyntaxError: invalid syntax
    print '%s%s%s' % ('_' * width_new, txt, '_' * width_new)
                  ^
./dcmanager/common/exceptions.py:57:20: F821 undefined name 'unicode'
            return unicode(self.msg)
                   ^
./dcorch/common/exceptions.py:50:20: F821 undefined name 'unicode'
            return unicode(self.msg)
                   ^
./dcorch/drivers/openstack/sysinv_v1.py:405:59: F821 undefined name 'basestring'
                elif k == 'enabled' and not isinstance(v, basestring):
                                                          ^
ERROR: InvocationError: '/home/commit/stx-distcloud/.tox/pep8/bin/flake8'
__________________________________________________________________________________________________________________ summary __________________________________________________________________________________________________________________
ERROR: pep8: commands failed
root@ubuntu #

[Ghada Khalil (gkhalil)]

This is a duplicate of:
https://bugs.launchpad.net/starlingx/+bug/1799721

Fixes have already been submitted to starlingx master

[Ghada Khalil (gkhalil)]

As per input from Bart, this bug report is not a duplicate of https://bugs.launchpad.net/starlingx/+bug/1799721 as I initially thought. I've removed the link and re-opened this bug report.

The error above goes back to the initial submission of the distributed cloud code. There is a story open to fix this error and enable zuul for distributed cloud:
https://storyboard.openstack.org/#!/story/2003862

[Ghada Khalil (gkhalil)]

Assigning this bug report to Lachlan Plant, the owner of the storyboard.

[Ghada Khalil (gkhalil)]

There is already a review by jumboli to address the pep8 errors - linked to this bug:
https://review.openstack.org/#/c/611823/

Lachlan will use the story to address the remaining items.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/611823
Committed: https://git.openstack.org/cgit/openstack/stx-distcloud/commit/?id=0c34a4901df8b92aa461969387cb19ea391e8ccd
Submitter: Zuul
Branch: master

commit 0c34a4901df8b92aa461969387cb19ea391e8ccd
Author: junboli <email address hidden>
Date: Thu Oct 25 04:01:24 2018 +0800

    Fix pep8 error when running tox

    openstack-tox-pep8 now is failure, this patch is to fix
    this.

    Closes-bug: #1799930
    Change-Id: Ia1b7f3395e92014e0f5373d81788dc55f7815002