build-iso does not populate ISO "upgrades" path correctly

[Jason McKenna]

Title
-----
build-iso does not populate ISO "upgrades" path correctly

Brief Description
-----------------
build-iso reports the following error on build. build-iso completes with no error returned, although the "upgrades" path is not populated correctly on the newly produced ISO.

cp: cannot stat ‘/localdisk/designer/jenkins/R6_Dev_Test_Patch_Build/cgcs-root/stx/stx-metal/bsp-files/upgrades/*’: No such file or directory

Severity
--------
Major

Steps to Reproduce
------------------
Execute build-iso after building packages with build-pkgs

Expected Behavior
------------------
Error was not expected to be observed, upgrades expected to contain several files

Actual Behavior
----------------
Error observed in output and only one file copied to ISO /upgrades/ path

Reproducibility
---------------
100% Reproducible

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
Oct 19, 0100 UTC

Timestamp/Logs

Output of build-iso (note the process completes without error):

...
20:46:08 20:46:08 cp: cannot stat ‘/localdisk/designer/jenkins/StarlingX_Upstream/cgcs-root/stx/stx-metal/bsp-files/bsp-files/upgrades/*’: No such file or directory
20:46:08 20:46:08 sed: can't read /localdisk/loadbuild/jenkins/StarlingX_Upstream_build/2018-10-18_20-18-00/export/dist/isolinux/upgrades/metadata.xml: No such file or directory
20:46:08 20:46:08 chmod: cannot access ‘/localdisk/loadbuild/jenkins/StarlingX_Upstream_build/2018-10-18_20-18-00/export/dist/isolinux/upgrades/*.sh’: No such file or directory

[Ghada Khalil (gkhalil)]

Targeting stx.2019.03 -- this is future proofing. There are no upgrades planned for stx releases currently.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/611943

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/611943
Committed: https://git.openstack.org/cgit/openstack/stx-root/commit/?id=a54ec44013da952ff6a0e1bdbafe831e57514789
Submitter: Zuul
Branch: master

commit a54ec44013da952ff6a0e1bdbafe831e57514789
Author: Jason McKenna <email address hidden>
Date: Fri Oct 19 15:48:36 2018 -0400

    Properly populate "upgrades" path on ISO

    The build-iso script was attempting to populate the "upgrades"
    path of the ISO from an invalid source. This change uses the
    correct source files for population of the path.

    Change-Id: I28d0a762052b9dcaf0cad85d52207404e5919474
    Closes-Bug: 1798890
    Signed-off-by: Jason McKenna <email address hidden>