host type check wrong in virt-support-goenabled.sh

[chen haochuan]

Title
 -----
 host type check method wrong in virt-support-goenabled.sh

Severity
 --------
Critical

stx-metal/mtce-compute/cgts-mtce-compute-1.0/scripts/virt-support-goenabled.sh

Line 50:
if [ "${host_type}" = "physical" ] && [ "${hardware_virt_supported}" == "false" ]; then

should be

if [ "${host_type}" == "physical" ] && [ "${hardware_virt_supported}" == "false" ]; then

[Brent Rowsell (brent-rowsell)]

Please describe the issue.
There is insufficient information on this bug description

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/612235

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/612235
Committed: https://git.openstack.org/cgit/openstack/stx-metal/commit/?id=50b77e7d62be2eb94db99a3ba84aa0aee80c7a17
Submitter: Zuul
Branch: master

commit 50b77e7d62be2eb94db99a3ba84aa0aee80c7a17
Author: Martin Chen <email address hidden>
Date: Tue Oct 23 05:14:07 2018 +0800

    Fix host check wrong in virt-support-goenabled.sh

    Closes-Bug: 1798773

    Change-Id: Ie62b7dfdf835ef60f9e7ba81f60dbcc517417a78
    Signed-off-by: Martin Chen <email address hidden>

[Ghada Khalil (gkhalil)]

Marking as Low importance; there is no information in this bug regarding the actual scenario this coding bug is causing. In the gerrit the review, the original author is of the opinion that there is no negative impact (From Jim Gauld: "I am not convinced there is anything functionally wrong with the original bash code due to how bash operator "=" vs "==" works within the "[". The appearance looks better after your change, however.")