LLDP System Description shown as Titanium Cloud version 18.10 on switch side

[Chris Winnicki]

Title
-----
LLDP System Description shown as Titanium Cloud version 18.10 on switch side

Brief Description
-----------------

Severity
--------
Critical: Minor

Steps to Reproduce
------------------
Install ironpass-1_4 lab
Run lab_setup to completion
Unlock compute hosts

Show lldp neigbour info of data interface on quanta-1

Expected Behavior
------------------
LLDP System Description should not show Titanium Cloud version 18.10 on switch side

Actual Behavior
----------------

show lldp neighbors interface xe23

Local Interface ......................... xe23
Remote Index ............................ 2962
Remote Port ............................. F2:22:C1:69:2F:EB
Port Subtype ............................ 3
Chassis Subtype ......................... 4
Chassis ................................. 90:E2:BA:48:7C:B8
MAC Address ............................. F2:22:C1:69:2F:EB
System Capability Supported ............. bridge, access-point, router, station-only
System Capability Enabled ............... station-only
Port Description ........................ lldpe74c2606-c8
System Name ............................. compute-0:yow-cgcs-ironpass-1_4
System Description ...................... Titanium Cloud version 18.10

Learned management address configuration data on interface:

Local Interface Address Address Address Address Interface Address OID
                                         Subtype Interface ID ID Subtype
--------------- ------------------------ ------- ------------ ----------------- ----------------------------
xe23 192.168.204.148 ipv4 4 if-index N/A
xe23 fe80::21e:67ff:fe51:5709 ipv6 4 if-index N/A

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Any system

Branch/Pull Time/Commit
-----------------------
master as of 2018-10-01_20-18-00

Timestamp/Logs
--------------
n/a

[Ghada Khalil (gkhalil)]

Related to ovs-dpdk lldp feature support. The nodes should not advertise "Titanium Cloud" for the stx code base. Gating stx.2018.10.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/610971

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/2018.10
Review: https://review.openstack.org/611319

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/610971
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=b3fe6052874d69975c33fd4e6d352eb4e53d7da4
Submitter: Zuul
Branch: master

commit b3fe6052874d69975c33fd4e6d352eb4e53d7da4
Author: Steven Webster <email address hidden>
Date: Mon Oct 15 13:35:37 2018 -0400

    Modify default lldp system description

    This commit modifies the default system description configuration
    for the lldpd daemon to remove a product specific name and version.
    Instead, the OS name and version (default used by lldpd) will be
    used. For example, for a CentOS host, the system description would
    look something like:

    CentOS Linux 7 (Core)

    For security reasons, we also pass the -k option to the
    lldpd process in order to prevent the specific kernel version to
    be broadcast.

    Change-Id: I2a15481b95d1e37bc2f4ae053a10c3289dd2f400
    Closes-Bug: #1796112
    Signed-off-by: Steven Webster <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/611319
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=71b4cc8a52a48fd6a175083046bc985adf326e8d
Submitter: Zuul
Branch: r/2018.10

commit 71b4cc8a52a48fd6a175083046bc985adf326e8d
Author: Steven Webster <email address hidden>
Date: Mon Oct 15 13:35:37 2018 -0400

    Modify default lldp system description

    This commit modifies the default system description configuration
    for the lldpd daemon to remove a product specific name and version.
    Instead, the OS name and version (default used by lldpd) will be
    used. For example, for a CentOS host, the system description would
    look something like:

    CentOS Linux 7 (Core)

    For security reasons, we also pass the -k option to the
    lldpd process in order to prevent the specific kernel version to
    be broadcast.

    Change-Id: I2a15481b95d1e37bc2f4ae053a10c3289dd2f400
    Closes-Bug: #1796112
    Signed-off-by: Steven Webster <email address hidden>