cinder upload to image doesn't work for in-use volume when force option used

[Irina Mihai]

Brief Description
-----------------
User is unable to upload an in-use volume to image when using the force option.
This happens in both GUI and CLI.

Severity
--------
Standard

Steps to Reproduce
------------------
- create bootable volume and boot image from volume
- try uploading the in-use volume to image using the force option (CLI or horizon) -> it should work

Expected Behavior
------------------
User is able to upload an in-use volume to image when using the force option.
This happens in both GUI and CLI.

Actual Behavior
----------------
Error when trying to upload in-use volume to image using the force option.

Reproducibility
---------------
100%

System Configuration
--------------------
Any node with cinder configured.

Branch/Pull Time/Commit
-----------------------
Master as of date: 2018-10-01

Timestamp/Logs
--------------
GUI error:
Error: Unable to upload volume to image for volume: "Volume Name"'.

CLI error:
[wrsroot@controller-0 ~(keystone_admin)]$ cinder list |grep use
| 53bb2ae4-a5ba-47b2-a530-0434e1872587 | in-use | myTestVol1 | 1 | - | true | caf2ed84-e279-45a1-a791-62a56c0e5f05 |
[wrsroot@controller-0 ~(keystone_admin)]$ cinder upload-to-image myTestVol1 test_vol_img --force
ERROR: Invalid volume: Volume 53bb2ae4-a5ba-47b2-a530-0434e1872587 status must be available (HTTP 400) (Request-ID: req-c41b4ec6-b3e4-4e3c-8477-3f4e8b22eb6f)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/607355

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/607355
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=e38b58cdee2ba3e832eca46f713bda94e8cf74c2
Submitter: Zuul
Branch: master

commit e38b58cdee2ba3e832eca46f713bda94e8cf74c2
Author: Irina Mihai <email address hidden>
Date: Tue Oct 2 19:37:48 2018 +0000

    Allow uploading an in-use volume to image using force option

    As by default, cinder does not allow uploading an in-use volume
    to image, enable that in the cinder puppet manifest.

    Change-Id: I067c23ae896fa7de921e8e8bb67430aac7f9cab8
    Closes-Bug: 1795652
    Signed-off-by: Irina Mihai <email address hidden>

[Ghada Khalil (gkhalil)]

Targeting stx.2019.03 as this is a specific use-case which is not very common