"String not null terminated" issues reported by static analysis in Stx-metal

[chen haochuan]

Title
-----
There is "String not null terminated" issue reported by static analysis in "stx-metal"

Brief Description
-----------------
stx/stx-metal/mtce/src/rmon/rmonMsg.cpp
function:
int rmon_service_inbox ( int clients )

line#525
bytes = recvfrom( rmon_sock.rmon_tx_sock, buf, RMON_MAX_LEN, 0, (struct sockaddr *)&rmon_sock.rmon_tx_addr, &len);
if ( bytes > 0 )
{
Comment:
in bytes > 0 branch, propose add buf[RMON_MAX_LEN-1] = '\0';

stx/stx-metal/mtce/src/public/amon.c
function:
int active_monitor_dispatch ( void )

line#212
rc = recvfrom ( amon.rx_sock, amon.rx_buf, AMON_MAX_LEN, 0,
                (struct sockaddr *)&amon.rx_addr, &len);
propose add amon.rx_buf[AMON_MAX_LEN-1] = '\0'

stx/stx-metal/mtce/src/maintenance/mtcCtrlMsg.cpp
function:
int mtc_service_inbox ( nodeLinkClass * obj_ptr,
                        mtc_socket_type * sock_ptr,
                        int iface)
line#130 --- line#145
if ( iface == INFRA_INTERFACE )
{
    if ( ( obj_ptr ) &&
         ( obj_ptr->infra_network_provisioned == true ) &&
         ( sock_ptr->mtc_agent_infra_rx_socket ))
    {
        bytes = sock_ptr->mtc_agent_infra_rx_socket->read((char*)&msg, sizeof(msg));
    }
    else
    {
        return ( FAIL_NO_INFRA_PROV );
    }
}
else
{
    bytes = sock_ptr->mtc_agent_rx_socket->read((char*)&msg, sizeof(msg));
}

add msg.buf[BUF_SIZE-1] = '\0'

stx/stx-metal/mtce/src/hwmon/hwmonMsg.cpp

int hwmon_service_inbox ( void )

line#227 --- line#230
memset ((void*)&msg,0,sizeof(mtc_message_type));
bytes = hwmon_sock.cmd_sock->read((char*)&msg.hdr[0], sizeof(mtc_message_type));
if( bytes <= 0 )
{
    if ( ( errno == EINTR ) || ( errno == EAGAIN ))
    {
        return (RETRY);
    }
    else
    {
        elog ("receive error (%d:%s)\n", errno , strerror (errno));
        return (FAIL_TO_RECEIVE);
    }
}

msg.buf[BUF_SIZE-1] = '\0'

stx/stx-metal/mtce/src/hostw/hostwHdlr.cpp

int hostw_service_command ( hostw_socket_type * hostw_socket)

line#175 --- line#180
mtc_message_type msg[2]; /* we use a chunk of memory larger than a single
                          * mtc_message_type to check for oversized messages
                          * (invalid...)
                          */
int len = sizeof(msg[0]) + 1;

add
memset(&msg, 0, 2*sizeof(msg[0]));

Severity
--------
Critical: there is possibility of string malfunction
Steps to Reproduce
------------------
Run code static analysis tool

Expected Behavior
------------------
no risk of string malfunction

Reproducibility
---------------
Always

System Configuration
--------------------
All case

[haitao wang (hwang85)]

https://review.openstack.org/#/c/615478/