Attempting to install controller-0 fails from host setup vie pxeboot_setup.sh

[Chris Winnicki]

Title
-----
Attempting to install controller-0 fails from host setup vie pxeboot_setup.sh

Brief Description
-----------------
Attempting to install controller-0 fails from host setup vie pxeboot_setup.sh
fails with:
error: variable `root' isn't set.
error: you need to load the kernel first.

Severity
--------
Critical: Attempting to install controller-0 fails from host setup vie pxeboot_setup.sh

Steps to Reproduce
------------------
1)
Steps to reproduce:
- Build ISO based on master as of 2018-09-24_20-18-00
- copy latest bootimage.iso to a designated PXBoot server (as per pxeboot_setup documentation)
- mount the iso and run pxeboot_setup.sh
ex:
sudo mount -o loop /tmp/latest_bootimage.iso /media/iso/98812
sudo mount -o remount,exec,dev /media/iso/98812
cd /media/iso/98812
/media/iso/98812/pxeboot_setup.sh -u http://123.123.123.110:8000/html/umalab/98812/ -t /export/pxeboot/pxeboot.cfg/98812

cd /export/pxeboot/pxeboot.cfg/98812/EFI
ln -s ../grub.cfg grub.cfg-01-3c-fd-fe-b5-72-e5

2)
Attempt to pxeboot controller-0

Expected Behavior
------------------
controller-0 should install via server setup by pxeboot_setup.sh

Ex: Install menu cames up (option 3 is selected)
      1) UEFI Boot from hard drive
      UEFI Standard Controller
      UEFI All-in-one Controller
      UEFI All-in-one (lowlatency) Controller

"STANDARD Security Boot Profile" is selected

At this point the install should start

Actual Behavior
----------------
Actual:

error: variable `root' isn't set.
error: you need to load the kernel first.
Press any key to continue...

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Any system

Branch/Pull Time/Commit
-----------------------
master as of 2018-09-24_20-18-00

Timestamp/Logs
--------------
n/a

[Ghada Khalil (gkhalil)]

Targeting stx.2019.03 as this is a very specific install option

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/606982

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/606982
Committed: https://git.openstack.org/cgit/openstack/stx-metal/commit/?id=3f337d5edb1fe2a6efa1d64d58e221017e165f0b
Submitter: Zuul
Branch: master

commit 3f337d5edb1fe2a6efa1d64d58e221017e165f0b
Author: Kristine Bujold <email address hidden>
Date: Mon Oct 1 11:14:25 2018 -0400

    Fix bug with PXE Boot Server

    The UEFI grub config file used for PXE Boot Server containes a mixed
    of menuentry and submenu. A submenu opens a new context and global
    variables cannot be used within them
    https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1175127. This
    was causing pxe_root to be empty for submenus selections. Moving
    '1) UEFI Boot from hard drive' into a submenu fixes this problem and
    also removes the need to save the root variable. This was previously
    required when a user would select boot from hard drive and the hard
    drive did not exist, root would no longer be set to the pxeboot
    server and selecting the other menu entries would fail.

    Remove the '1)' prefix in the 'Boot from hard drive' menu option in
    both Legacy and UEFI boot as this is not used by other menues.

    Closes-Bug: 1794863

    Change-Id: I5bc62039bfb68477e9cd0166ce17877693037640
    Signed-off-by: Kristine Bujold <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/620139

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/620139
Committed: https://git.openstack.org/cgit/openstack/stx-metal/commit/?id=0715862fa51b69fcab60c76b5506d258e08586f5
Submitter: Zuul
Branch: master

commit 0715862fa51b69fcab60c76b5506d258e08586f5
Author: Kristine Bujold <email address hidden>
Date: Mon Nov 26 13:53:44 2018 -0500

    PXE Boot Server robustness

    This commits add the creation of a symlink for EFI/grub.cfg. It also
    allows the user to overwrite an existing directory, the user will be
    prompted to confirm this action.

    Closes-Bug: 1794863

    Change-Id: I566a3b39c601921cd73cca3f291f43e5dc0ef626
    Signed-off-by: Kristine Bujold <email address hidden>