static analysis reports "Buffer not null terminated" issues in stx-fault/fm_common

[Ran An]

Brief Description
-----------------
  in some files it use 'sncpy()' function which can not guarantee null termination of the string. This will lead a further security issue: "If the buffer is treated as a null terminated string in later operations, a buffer overflow or over-read may occur."

Severity
--------
 Major

Steps to Reproduce
------------------
  use function 'snprintf()' instead of 'sncpy()'

Expected Behavior
------------------
  static analysis do not report this issue

Actual Behavior
----------------
  static analysis report this issue

Reproducibility
---------------
Reproducible

System Configuration
--------------------
all

Static Analysis Reports
--------------------
Buffer not null terminated
If the buffer is treated as a null terminated string in later operations, a buffer overflow or over-read may occur.

fmAlarmUtils.cpp:228
buffer_size_warning: Calling strncpy with a maximum size argument of 255 bytes on destination array a->entity_type_id of size 255 bytes might leave the destination string unterminated

similar cases at
  fmAlarmUtils.cpp:213,
  fmAlarmUtils.cpp:218,
  fmAlarmUtils.cpp:233,
  fmAlarmUtils.cpp:251,
  fmAlarmUtils.cpp:266,
  fmAlarmUtils.cpp:464,
  fmAlarmUtils.cpp:465,
  fmDbAlarm.cpp:301,
  fmDbAlarm.cpp:341,
  fmDbAlarm.cpp:457,
  fmDbEventLog.cpp:312

[Bruce Jones (brucej)]

Please update this bug with specific file and line number information for the static analysis issue. Make sure the bug has enough information for someone to find the problem in the code without access to the tool or the report.

[haitao wang (hwang85)]

associated review addr: https://review.openstack.org/#/c/612281/