login banner/welcome showing wrong message on ssh login attempt

[mhg]

Brief Description
-----------------
When ssh to a lab, the system is showing, e.g: ssh -l wrsroot 128.224.150.221
\S
Kernel \r on an \m
wrsroot@128.224.150.221's password:

The system is showing the contents of /etc/issue on the load.

Severity
--------
Minor

Steps to Reproduce
------------------
Attempt to connect to the target system using SSH, e.g.:
ssh -l wrsroot 128.224.150.221

Expected Behavior
------------------
Previous loads show:Release 18.08
------------------------------------------------------------------------
W A R N I N G *** W A R N I N G *** W A R N I N G *** W A R N I N G ***
------------------------------------------------------------------------
THIS IS A PRIVATE COMPUTER SYSTEM.
This computer system including all related equipment, network devices
(specifically including Internet access), are provided only for authorized use.
All computer systems may be monitored for all lawful purposes, including to
ensure that their use is authorized, for management of the system, to
facilitate protection against unauthorized access, and to verify security
procedures, survivability and operational security. Monitoring includes active
attacks by authorized personnel and their entities to test or verify the
security of the system. During monitoring, information may be examined,
recorded, copied and used for authorized purposes. All information including
personal information, placed on or sent over this system may be monitored. Uses
of this system, authorized or unauthorized, constitutes consent to monitoring
of this system. Unauthorized use may subject you to criminal prosecution.
Evidence of any such unauthorized use collected during monitoring may be used
for administrative, criminal or other adverse action. Use of this system
constitutes consent to monitoring for these purposes.

wrsroot@128.224.151.49's password:

Actual Behavior
----------------
Now:

$ ssh -l wrsroot 128.224.150.221
\S
Kernel \r on an \m
wrsroot@128.224.150.221's password:

Reproducibility
---------------
Reproducible:
yes

System Configuration
--------------------
One node system

Branch/Pull Time/Commit
-----------------------
master as of 2018-09-24_20-18-00

Timestamp/Logs
--------------
2018-09-25 15:44:00

[Ghada Khalil (gkhalil)]

This maybe related to the CentOS 7.5 rebase. Adding the stx.distro.other label.

[Michel Thebeau [WIND] (mthebeau)]

I found the reversion appeared first on a stx upstream build dated 2018-09-20

I found that the centos-release binary rpm has default text for /etc/issue and /etc/issue.net, instead of what should be presented due to the meta-patches against the spec file for centos-release. I did not spot the cause. The .spec file in the result src.rpm file looks correct and unchanged, but the binary rpm from the same build has the default issue files instead of the provided ones.

[Ghada Khalil (gkhalil)]

Schuicheng confirmed that this issue was indeed intrdouced by the centos 7.5 src rpm upgrade.
A fix is out for review:
https://review.openstack.org/605285

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/605285
Committed: https://git.openstack.org/cgit/openstack/stx-integ/commit/?id=ddbe0e69c955203fa2c1f55cdcefd78d27150b6e
Submitter: Zuul
Branch: master

commit ddbe0e69c955203fa2c1f55cdcefd78d27150b6e
Author: slin14 <email address hidden>
Date: Wed Sep 26 18:56:06 2018 +0800

    Fix console/ssh login banner revert to default issue

    Closes-Bug: 1794329

    It is due to the "overwrite default issue file" cmd rebased to wrong
    position when do CentOS7.5 upgrade.
    Also rename the meta patch filename to align with the PATCH_ORDER.

    Change-Id: Ic081e213c002ea8a3d4b59a98d342bfa04c6b0fc
    Signed-off-by: slin14 <email address hidden>