Attaching platform network to data interface creation not rejected via CLI

[Senthil Mukundakumar]

Brief Description
-----------------------

In GUI, there is no option to choose any platform class network to attach to data interface.

But in CLI, it allows platform network to attach to data when creating data interface.

Severity
--------
Minor

Steps to Reproduce
--------------------------
[wrsroot@controller-0 ~(keystone_admin)]$ system network-list
+----+--------------------------------------+-----------+-----------+---------+--------------------------------------+
| id | uuid | name | type | dynamic | pool_uuid |
+----+--------------------------------------+-----------+-----------+---------+--------------------------------------+
| 1 | 72938abe-50a7-468b-b49a-af32fd71b4fd | mgmt | mgmt | True | 74abcf13-31f8-4472-a6bf-747e9b41e39e |
| 5 | 7b2caae4-a9db-44a3-b44f-df5810243741 | multicast | multicast | False | 87bab712-57fb-4dff-ac19-2fa9922e6dfd |
| 3 | 99965b24-7895-4933-b3be-533dcb9ee59c | infra | infra | True | a725cbec-6516-46c7-bc8b-8012cdce8652 |
| 2 | c0f29e2b-659e-41ef-9fa5-cbfbae696b43 | pxeboot | pxeboot | True | 8000119a-f591-4f47-8e85-9f657ddb8ba9 |
| 4 | c3372f8e-b867-4575-a3be-66429492a061 | oam | oam | False | d885faac-0ab9-4aaf-95e9-3e67e75b7e3f |
+----+--------------------------------------+-----------+-----------+---------+---------------------------

Attach infra network to data interface

[wrsroot@controller-0 ~(keystone_admin)]$ system host-if-modify -n data11 -p group0-data3 -c data --networks 99965b24-7895-4933-b3be-533dcb9ee59c compute-0 fdb8389f-9078-4c9b-a7e6-cf1bc68e0e3f
+------------------+--------------------------------------+
| Property | Value |
+------------------+--------------------------------------+
| ifname | data11 |
| iftype | ethernet |
| ports | [u'eno1'] |
| providernetworks | group0-data3 |
| imac | a4:bf:01:19:95:b6 |
| imtu | 1500 |
| ifclass | data |
| networks | infra |
| aemode | None |
| schedpolicy | None |
| txhashpolicy | None |
| uuid | fdb8389f-9078-4c9b-a7e6-cf1bc68e0e3f |
| ihost_uuid | c206c8a5-72ce-447a-956d-1c69a2fb1e00 |
| vlan_id | None |
| uses | [] |
| used_by | [] |
| created_at | 2018-09-20T22:16:46.780462+00:00 |
| updated_at | 2018-09-21T20:02:58.349572+00:00 |
| sriov_numvfs | 0 |
| ipv4_mode | disabled |
| ipv6_mode | disabled |
| accelerated | [True] |
+------------------+--------------------------------------+

Expected Behavior
------------------ -------
Data Interface create with platform class network should be rejected

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Any

Branch/Pull Time/Commit
-----------------------
StarlingX master as of 2018-09-19_20-18-00

[Ghada Khalil (gkhalil)]

Issue is related to the Generalized Interface and Network Configuration Feature:
https://storyboard.openstack.org/#!/story/2003087
which was recently submitted

However, this is just a missing semantic check. The issue can be avoided by not attempting this operation. Targeting stx.2019.03

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/607005

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/607005
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=4cb0a700ad0d0b1287ff2cf03e5fb7d0c18a0837
Submitter: Zuul
Branch: master

commit 4cb0a700ad0d0b1287ff2cf03e5fb7d0c18a0837
Author: Teresa Ho <email address hidden>
Date: Thu Sep 27 15:55:37 2018 -0400

    Disallow network associated to non-platform interface

    This update blocks the assignment of platform network to an interface
    with a class of data, pci-passthrough or pci-sriov.

    Closes-Bug: 1793824

    Change-Id: I870fd7c969d461e3178c89e41a4bd1c68a134c89
    Signed-off-by: Teresa Ho <email address hidden>