pxeboot network allowed to be created multiple times when its already provisioned

[Senthil Mukundakumar]

Brief Description
-----------------------

Only one oam, infra, mgmt & pxeboot can be created per node. For pxeboot network it allows user to create multiple times.

Severity
--------
Major

Steps to Reproduce
--------------------------
1. Add pxeboot network to already provisioned node
[wrsroot@controller-0 ~(keystone_admin)]$ system network-list
+----+--------------------------------------+-----------+-----------+---------+--------------------------------------+
| id | uuid | name | type | dynamic | pool_uuid |
+----+--------------------------------------+-----------+-----------+---------+--------------------------------------+
| 1 | 72938abe-50a7-468b-b49a-af32fd71b4fd | mgmt | mgmt | True | 74abcf13-31f8-4472-a6bf-747e9b41e39e |
| 5 | 7b2caae4-a9db-44a3-b44f-df5810243741 | multicast | multicast | False | 87bab712-57fb-4dff-ac19-2fa9922e6dfd |
| 3 | 99965b24-7895-4933-b3be-533dcb9ee59c | infra | infra | True | a725cbec-6516-46c7-bc8b-8012cdce8652 |
| 2 | c0f29e2b-659e-41ef-9fa5-cbfbae696b43 | pxeboot | pxeboot | True | 8000119a-f591-4f47-8e85-9f657ddb8ba9 |
| 4 | c3372f8e-b867-4575-a3be-66429492a061 | oam | oam | False | d885faac-0ab9-4aaf-95e9-3e67e75b7e3f |
+----+--------------------------------------+-----------+-----------+---------+--------------------------------------+
2[wrsroot@controller-0 ~(keystone_admin)]$ system host-if-modify -n pxeboot1 -c platform --networks c0f29e2b-659e-41ef-9fa5-cbfbae696b43 controller-1 11172da1-ec47-4340-a7a2-96ef75f86ed4
+------------------+--------------------------------------+
| Property | Value |
+------------------+--------------------------------------+
| ifname | pxeboot1 |
| iftype | ethernet |
| ports | [u'ens785f1'] |
| providernetworks | None |
| imac | 3c:fd:fe:ac:64:a1 |
| imtu | 1500 |
| ifclass | platform |
| networks | pxeboot |
| aemode | None |
| schedpolicy | None |
| txhashpolicy | None |
| uuid | 11172da1-ec47-4340-a7a2-96ef75f86ed4 |
| ihost_uuid | 2bf3a912-927f-42a2-bddb-68304edcfa7c |
| vlan_id | None |
| uses | [] |
| used_by | [] |
| created_at | 2018-09-20T22:17:02.930096+00:00 |
| updated_at | 2018-09-21T15:25:55.681250+00:00 |
| sriov_numvfs | 0 |
| accelerated | [True] |
+------------------+--------------------------------------+

2. [wrsroot@controller-0 ~(keystone_admin)]$ system host-if-list controller-1
+--------------------------------------+----------+----------+----------+---------+---------------+---------------+------------------------+------------+-------------------+
| uuid | name | class | type | vlan id | ports | uses i/f | used by i/f | attributes | provider networks |
+--------------------------------------+----------+----------+----------+---------+---------------+---------------+------------------------+------------+-------------------+
| 04087d27-ab23-440b-a12a-8c329bc91c22 | mgmt0 | platform | vlan | 166 | [] | [u'pxeboot0'] | [] | MTU=1500 | None |
| 11172da1-ec47-4340-a7a2-96ef75f86ed4 | pxeboot1 | platform | ethernet | None | [u'ens785f1'] | [] | [] | MTU=1500 | None |
| 32c70564-3d6f-46ad-994b-6dee8f5e1854 | vlan167 | platform | vlan | 167 | [] | [u'pxeboot0'] | [] | MTU=1500 | None |
| 85c0caab-8e9e-4088-a579-023a487d343c | pxeboot0 | platform | ethernet | None | [u'ens785f0'] | [] | [u'vlan167', u'mgmt0'] | MTU=9216 | None |
| d70376d5-b0f9-4ca7-badf-7c622bc3de6a | oam0 | platform | ethernet | None | [u'eno1'] | [] | [] | MTU=1500 | None |
+--------------------------------------+----------+----------+----------+---------+---------------+---------------+------------------------+------------+-------------------+

Expected Behavior
------------------ -------

It should be rejected as other platform network type: Oam, infra, mgmt
[wrsroot@controller-0 ~(keystone_admin)]$ system host-if-modify -n oam1 -c platform --networks c3372f8e-b867-4575-a3be-66429492a061 controller-1 11172da1-ec47-4340-a7a2-96ef75f86ed4
An interface with 'oam' network type is already provisioned on this node
[wrsroot@controller-0 ~(keystone_admin)]$ system host-if-modify -n mgmt1 -c platform --networks 72938abe-50a7-468b-b49a-af32fd71b4fd controller-1 11172da1-ec47-4340-a7a2-96ef75f86ed4
An interface with 'mgmt' network type is already provisioned on this node
[wrsroot@controller-0 ~(keystone_admin)]$ system host-if-modify -n infra1 -c platform --networks 99965b24-7895-4933-b3be-533dcb9ee59c controller-1 11172da1-ec47-4340-a7a2-96ef75f86ed4
An interface with 'infra' network type is already provisioned on this node

Actual Behavior
---------------------
Creation of multiple pxeboot platform network allowed

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Any

Branch/Pull Time/Commit
-----------------------
StarlingX master as of 2018-09-19_20-18-00

[Ghada Khalil (gkhalil)]

Targeting stx.2018.10 for now; this issue is related to the Generalized Interface and Network Configuration Feature:
https://storyboard.openstack.org/#!/story/2003087
which was recently submitted

If this cannot be addressed within the needed deadline, it can be re-gated since it's not a major issue. The issue can be avoided by not creating multiple pxeboot networks.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/604676

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/604676
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=f73e5fecf0af73997b8ede6bc6998245a9ceec80
Submitter: Zuul
Branch: master

commit f73e5fecf0af73997b8ede6bc6998245a9ceec80
Author: Patrick Bonnell <email address hidden>
Date: Sun Sep 23 23:55:10 2018 -0400

    Prevent pxeboot network from multiple provisions

    This commit prevents the pxeboot network from being assigned
    multiple times on the same node.

    Closes-Bug: 1793789

    Change-Id: I3a574f7a3eae9cade67d9f7fe043ba2e7b0938b6
    Signed-off-by: Patrick Bonnell <email address hidden>