controllerfs-modify is failing with error object has no attribute 'ialarm_get_all'

[Anujeyan Manokeran]

Bug Description : During the initial stage of install procedure after the config controller is executed controllerfs-modify was not working .

  system controllerfs-modify backup=50
'Connection' object has no attribute 'ialarm_get_all'
Sysinv logs show below.

ontrollers.v1.host [-] controller-0 ihost_patch_start_2018-09-19-18-22-12 patch
2018-09-19 18:22:12.991 40433 INFO sysinv.api.controllers.v1.host [-] controller-0 ihost_patch_end. No changes from mtce/1.0.
2018-09-19 18:25:03.793 40435 INFO sysinv.api.controllers.v1.controller_fs [-] _check_controller_multi_fs_data cgtsvg_growth_gib=20
2018-09-19 18:25:03.805 40435 ERROR wsme.api [-] Server-side error: "'Connection' object has no attribute 'ialarm_get_all'". Detail:
Traceback (most recent call last):

  File "/usr/lib/python2.7/site-packages/wsmeext/pecan.py", line 84, in callfunction
    result = f(self, *args, **kwargs)

  File "/usr/lib64/python2.7/site-packages/sysinv/api/controllers/v1/controller_fs.py", line 879, in update_many
    if _check_controller_state():

  File "/usr/lib64/python2.7/site-packages/sysinv/api/controllers/v1/controller_fs.py", line 373, in _check_controller_state
    entity_instance_id_filter="controller-")

  File "/usr/lib64/python2.7/site-packages/sysinv/common/health.py", line 127, in get_alarms_degrade
    db_alarms = self._dbapi.ialarm_get_all(include_suppress=True)

  File "/usr/lib/python2.7/site-packages/oslo_db/api.py", line 245, in __getattr__
    attr = getattr(self._backend, key)

AttributeError: 'Connection' object has no attribute 'ialarm_get_all'

Severity
--------
Major

Steps to Reproduce
------------------
Follow install procedure
1.Install controller
2.Config controller
3. Execute system controllerfs-modify backup=50 as per description error is produced.

Expected Behavior
------------------
No failure on controllerfs-modify

Actual Behavior
----------------
As per description

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Storage system

Branch/Pull Time/Commit
-----------------------
Master build of 2018-09-18_20-18-0

Timestamp/Logs
--------------
2018-09-19 18:25:03.805

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/604440

[Ghada Khalil (gkhalil)]

Targeting stx.2018.10 as this issue causes a large number of TCs to fail

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/604440
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=8ea2fa94d75fa2fa4d7a33a2cbd4aba9faca0a5d
Submitter: Zuul
Branch: master

commit 8ea2fa94d75fa2fa4d7a33a2cbd4aba9faca0a5d
Author: Tao Liu <email address hidden>
Date: Fri Sep 21 13:12:54 2018 -0400

    controllerfs-modify failed due to ialarm_get_all error

    The controllerfs-modify and host-swact commands trigger
    get_alarms_degrade query when the host is in degraded state.
    The get_alarms_degrade method still uses the database query
    ialarm_get_all() which is no longer supported. As a result,
    the command failed due to no attribute error.

    This update modifies get_alarms_degrade to query alarms via fmclient.

    Closes-Bug: 1793552

    Change-Id: I92ab034a43ceed7f372ba63f5f5fb412f1907281
    Signed-off-by: Tao Liu <email address hidden>