Interface-Network association did not get set to removed when interface was set to none

[Maria Yousaf]

Title
-----
Interface-Network association did not get set to removed when interface was set to none

Brief Description
-----------------
system host-if-modify controller-1 mgmt0 -n ens785f0 -c none was run. This did not result in the interface-network association being removed.

Severity
--------
Major

Steps to Reproduce
------------------
system host-if-modify controller-1 mgmt0 -n ens785f0 -c none
system host-if-modify controller-1 ens785f1 -n ens785f1 -c none
system interface-network-list

Expected Behavior
------------------
Association removed.

Actual Behavior
----------------
Association still present:

[wrsroot@controller-0 ~(keystone_admin)]$ system interface-network-list
+--------------+--------------------------------------+----------+--------------+
| hostname | uuid | ifname | network_name |
+--------------+--------------------------------------+----------+--------------+
| controller-0 | 6cd71d26-1c9c-4368-b695-fbb0f5064992 | oam0 | oam |
| controller-1 | 7beb4200-9199-4e78-a7e2-c59e0f86d695 | ens785f0 | mgmt |
| controller-0 | 8cb16353-eed5-4658-9b82-1a985ccbbf69 | bond0 | mgmt |
+--------------+--------------------------------------+----------+--------------+

Reproducibility
---------------
Unknown

System Configuration
--------------------
Two node system

Branch/Pull Time/Commit
-----------------------
2018-09-18 20:19:28 -0400

Timestamp/Logs
--------------
2018-09-19 15:49:09

[Ghada Khalil (gkhalil)]

Targeting stx.2018.10; this issue is related to the Generalized Interface and Network Configuration Feature:
https://storyboard.openstack.org/#!/story/2003087
which was recently submitted.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/604128

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/604129

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/604128
Committed: https://git.openstack.org/cgit/openstack/stx-gui/commit/?id=71a1d09c8842d31e6db6d3d1c82da96fa1589746
Submitter: Zuul
Branch: master

commit 71a1d09c8842d31e6db6d3d1c82da96fa1589746
Author: Teresa Ho <email address hidden>
Date: Thu Sep 20 10:01:52 2018 -0400

    Move interface-network removal to restAPI

    Previously, the deletion of the interface-network records were done
    in the GUI.
    A list of interface-networks to be removed are passed to the restAPI
    for the deletion.

    Closes-Bug: 1793349

    Change-Id: I8d5a9b27255b8260d09e3e2e379a7e385e626c1c
    Signed-off-by: Teresa Ho <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/604129
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=b4e81b288df1718c71d3c20531fd91edd3cd42f8
Submitter: Zuul
Branch: master

commit b4e81b288df1718c71d3c20531fd91edd3cd42f8
Author: Teresa Ho <email address hidden>
Date: Thu Sep 20 09:09:41 2018 -0400

    Remove interface networks when class set to none

    When an interface class was modified from platform to none,
    the associated interface-network were not removed.
    This update deletes the interface-network records for the interface
    to disassociate the networks from the interface.

    Depends-On: https://review.openstack.org/604128
    Closes-Bug: 1793349

    Change-Id: I5eac2b4cb0ee62a8bf37c024aa08ca110ee80e7c
    Signed-off-by: Teresa Ho <email address hidden>