Horizon: Error viewing System Information page

[David Sullivan]

Brief Description
-----------------
When navigating to Admin -> System -> System Information horizon displays an error.

Severity
--------
Major: Unable to view System Information content

Steps to Reproduce
------------------
Browse to system information page

Expected Behavior
------------------
System information page is displayed

Actual Behavior
----------------
An error is displayed

Reproducibility
---------------
100% reproducible, may be config dependent

System Configuration
--------------------
Storage system with 3 computes.

Branch/Pull Time/Commit
-----------------------
2018-09-17_09-15-42

Timestamp/Logs
--------------
2018-09-18 13:26:40,894 [ERROR] django.request: Internal Server Error: /admin/info/
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/decorators.py", line 52, in dec
    return view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/decorators.py", line 36, in dec
    return view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/decorators.py", line 84, in dec
    return view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/decorators.py", line 52, in dec
    return view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/decorators.py", line 36, in dec
    return view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 71, in view
    return self.dispatch(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 89, in dispatch
    return handler(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/tabs/views.py", line 140, in get
    context = self.get_context_data(**kwargs)
  File "/usr/share/openstack-dashboard/openstack_dashboard/dashboards/admin/info/views.py", line 35, in get_context_data
    context = super(IndexView, self).get_context_data(**kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/tables/views.py", line 107, in get_context_data
    context = super(MultiTableMixin, self).get_context_data(**kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/tabs/views.py", line 55, in get_context_data
    exceptions.handle(self.request)
  File "/usr/lib/python2.7/site-packages/horizon/exceptions.py", line 364, in handle
    six.reraise(exc_type, exc_value, exc_traceback)
  File "/usr/lib/python2.7/site-packages/horizon/tabs/views.py", line 53, in get_context_data
    context["tab_group"].load_tab_data()
  File "/usr/lib/python2.7/site-packages/horizon/tabs/base.py", line 127, in load_tab_data
    exceptions.handle(self.request)
  File "/usr/lib/python2.7/site-packages/horizon/exceptions.py", line 364, in handle
    six.reraise(exc_type, exc_value, exc_traceback)
  File "/usr/lib/python2.7/site-packages/horizon/tabs/base.py", line 124, in load_tab_data
    tab._data = tab.get_context_data(self.request)
  File "/usr/lib/python2.7/site-packages/horizon/tabs/base.py", line 481, in get_context_data
    self.load_table_data()
  File "/usr/lib/python2.7/site-packages/horizon/tabs/base.py", line 462, in load_table_data
    table.data = data_func()
  File "/usr/share/openstack-dashboard/openstack_dashboard/dashboards/admin/info/tabs.py", line 196, in get_controller_services_data
    nodes = iservice.sm_nodes_list(self.tab_group.request)
  File "/usr/share/openstack-dashboard/openstack_dashboard/api/iservice.py", line 53, in sm_nodes_list
    nodes = sm_client(request).sm_nodes.list()
  File "/usr/lib/python2.7/site-packages/sm_client/v1/sm_nodes.py", line 41, in list
    return self._list(self._path(), "nodes")
  File "/usr/lib/python2.7/site-packages/sm_client/common/base.py", line 60, in _list
    resp, body = self.api.json_request('GET', url)
  File "/usr/lib/python2.7/site-packages/sm_client/common/http.py", line 201, in json_request
    resp, body_iter = self._http_request(url, method, **kwargs)
  File "/usr/lib/python2.7/site-packages/sm_client/common/http.py", line 168, in _http_request
    raise exc.CommunicationError(message=message)
CommunicationError: Error communicating with http://localhost:7777 [Errno 111] ECONNREFUSED

[David Sullivan (dsullivanwr)]

This issue presents because we have the iservice api both in stx-horizon and stx-gui. The code in in stx-horizon hasn't been updated with the bug fixes that were applied to stx-gui.

This commit needs to be applied to stx-horizon: https://github.com/openstack/stx-gui/commit/314a64a34f129b3e0b49daa4eb236a54ab4d6044

The iservice api should probably be removed from stx-gui. The code is only used in stx-horizon.

[Ghada Khalil (gkhalil)]

Targeting stx.2018.10 as this page is not usable

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/604178

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/604178
Committed: https://git.openstack.org/cgit/openstack/stx-gui/commit/?id=6dd15bf71f02641cbba32589656436e31da6bffb
Submitter: Zuul
Branch: master

commit 6dd15bf71f02641cbba32589656436e31da6bffb
Author: David Sullivan <email address hidden>
Date: Thu Sep 20 14:04:40 2018 -0400

    Remove iservice api from stx-gui

    The iservice api is used in stx-horzion. The code for this api should
    not be duplicated in stx-gui.

    Change-Id: I1a010542c5f3bf831c74f2a0053e87e58d0c817c
    Signed-off-by: David Sullivan <email address hidden>
    Closes-Bug: 1793348

[David Sullivan (dsullivanwr)]

Note this issue also requires https://github.com/starlingx-staging/stx-horizon/pull/15

[David Sullivan (dsullivanwr)]

Merged into stx-horizon
https://github.com/starlingx-staging/stx-horizon/commit/49a39f8baefb3e6ae3bc146dff5ea81966c09b7b