stx-tools libvirt all-in-one sizing/spec is incorrect

[Michel Thebeau [WIND]]

Title
-----
The all-in-one configuration in stx-tools/deployment/libvirt does not lead to a functional duplex configuration

Brief Description
-----------------

When following the wiki StarlingX/Installation_Guide_Virtual_Environment/Duplex, the sizing issues include:
 - insufficient RAM and cpu cores
 - a missing disks (the wiki instructions infer 3 disks)

It is partial the cause that the script setup_allinone.sh refers to controller.xml instead of controller_allinone.xml. However neither xml is correct.

Severity
--------
Minor

Steps to Reproduce
------------------
Follow wikis:
 StarlingX/Installation_Guide_Virtual_Environment
 StarlingX/Installation_Guide_Virtual_Environment/Duplex

Expected Behaviour
------------------
Wiki instructions lead to a functional duplex cluster

Actual Behaviour
----------------
Miscellaneous errors in configuration

Reproducibility
---------------
Reproducible (100%)

System Configuration
--------------------
per the wiki, duplex under virtualization per stx-tools/deployment/libvirt

Branch/Pull Time/Commit
-----------------------
stx-tools master branch, commit 8fd9efcc

Timestamp/Logs
--------------
n/a

[Michel Thebeau [WIND] (mthebeau)]

I have to clean up my changes and will submit shortly for review.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/603509

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/603510

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/603511

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/603512

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/603513

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/603514

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/603515

[Ghada Khalil (gkhalil)]

Targeting stx.2018.10 as these issues would prevent users from successfully configuring a duplex system following the wiki

[Juan Pablo Gomez (jpgomez)]

This bug is associated with the change at:

https://review.openstack.org/#/c/600127/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/600127
Committed: https://git.openstack.org/cgit/openstack/stx-tools/commit/?id=d98b4a2a37d0bd62d407e642af421f9e642cdf4f
Submitter: Zuul
Branch: master

commit d98b4a2a37d0bd62d407e642af421f9e642cdf4f
Author: Juan Pablo Gomez <email address hidden>
Date: Wed Sep 5 05:40:41 2018 -0400

    Libvirt: New Disk configuration added

    File controller_allinone.xml was modified in order to add a new DISK
    File setup_allinone.sh was modified for new Disk implementation

    Partial-Bug: 1793214
    Change-Id: I2953a74d3c78a87b4437bea550f645ec3838af38
    Signed-off-by: Juan Pablo Gomez <email address hidden>

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michel Thebeau (WIND) (<email address hidden>) on branch: master
Review: https://review.openstack.org/603509
Reason: JP's change set is merged instead:
https://review.openstack.org/600127

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/603510
Committed: https://git.openstack.org/cgit/openstack/stx-tools/commit/?id=9a6396bca38f9113128fe57fbc30fe9244c101be
Submitter: Zuul
Branch: master

commit 9a6396bca38f9113128fe57fbc30fe9244c101be
Author: Michel Thebeau <email address hidden>
Date: Mon Sep 24 10:23:20 2018 -0400

    deployment: libvirt: remove pci, bus, controllers

    Refer also to commit 10daff0c, which applies the change to
    controller.xml

    Some of the entries are invalid when changing the machine type, which is
    the next commit to follow this one.

    Libvirt will fill these things in correctly for the specified hardware.

    Related-Bug: #1793214

    Change-Id: I43593a7014713ab6ea9bfe73346fc0c6d0c41300
    Signed-off-by: Michel Thebeau <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/603511
Committed: https://git.openstack.org/cgit/openstack/stx-tools/commit/?id=96b8aa4226544131cb37e55053daf8c20ba096ad
Submitter: Zuul
Branch: master

commit 96b8aa4226544131cb37e55053daf8c20ba096ad
Author: Michel Thebeau <email address hidden>
Date: Tue Sep 18 16:00:18 2018 -0400

    deployment: libvirt: update machine type/model for all-in-one

    Refer also to commit 7abcd94a, which applies the change to
    controller.xml

    Tests should run on a comparably newer model of CPU and should be fixed
    for all tests under virtualization.

    Nehalem cpu model is recommended as one that has been used for this
    purpose for a few years.

    Specifying 'forbid' for fallback and 'exact' for mode will ensure that
    hosts the Qemu emulator is up-to-date on the host, capable of emulating
    the expect model. The consistency will make test results reliable
    across host machines.

    The newer machine type supports ACPI for example.

    The feature "vmx" is required on computes to support nesting.

    Related-Bug: #1793214

    Change-Id: Ib3e72d8c9fc528978358a7054b337672284f2908
    Signed-off-by: Michel Thebeau <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/603512
Committed: https://git.openstack.org/cgit/openstack/stx-tools/commit/?id=c7205a79b2e510dee19c35969416929fa15508b3
Submitter: Zuul
Branch: master

commit c7205a79b2e510dee19c35969416929fa15508b3
Author: Michel Thebeau <email address hidden>
Date: Tue Sep 18 16:05:14 2018 -0400

    deployment: libvirt: remove mac addresses all-in-one xml

    Listing the MACs in xml will cause both controllers to have the same MAC
    addresses.

    Libvirt will fill in mac addresses when the domains are defined.

    Partial-Bug: #1793214

    Change-Id: Ie8a5ea746dde61a2c8db7b8f48ff9948078de76f
    Signed-off-by: Michel Thebeau <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/603513
Committed: https://git.openstack.org/cgit/openstack/stx-tools/commit/?id=ec295b37c8c94819faa63a734f438c908e3d3233
Submitter: Zuul
Branch: master

commit ec295b37c8c94819faa63a734f438c908e3d3233
Author: Michel Thebeau <email address hidden>
Date: Tue Sep 18 16:09:06 2018 -0400

    deployment: libvirt: give all-in-one config six cores

    The all-in-one configuration has both controller and compute function on
    the controller nodes. More cores are required to run instances.

    Six cores allows 2 cores for instances.

    Partial-Bug: #1793214

    Change-Id: I1f2da957eb25eba1c488f58a6e94a74202b02a6b
    Signed-off-by: Michel Thebeau <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/603514
Committed: https://git.openstack.org/cgit/openstack/stx-tools/commit/?id=6108c459c9ec71737baede3aaae75873cdfc45e6
Submitter: Zuul
Branch: master

commit 6108c459c9ec71737baede3aaae75873cdfc45e6
Author: Michel Thebeau <email address hidden>
Date: Tue Sep 18 16:10:14 2018 -0400

    deployment: libvirt: give all-in-one 18G of RAM

    All-in-one with 18G will provide over 2G of RAM for instances. For
    example, a test configuration with two instances each with 1G RAM.

    This amount is less than the 24G listed in controller_allinone.xml,
    however all-in-one had been setup to use controller.xml, which provides
    16G, so technically the series of related commits is increasing the RAM
    for all-in-one from 16 to 18G.

    Partial-Bug: #1793214

    Change-Id: Id6556da171f43ba52375c33b8ab85b6d6d60c74d
    Signed-off-by: Michel Thebeau <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/603515
Committed: https://git.openstack.org/cgit/openstack/stx-tools/commit/?id=be8542eeaabd3f34c915033566591ccacdf99828
Submitter: Zuul
Branch: master

commit be8542eeaabd3f34c915033566591ccacdf99828
Author: Michel Thebeau <email address hidden>
Date: Mon Sep 17 18:17:02 2018 -0400

    deployment: libvirt: add disk to all-in-one cluster

    According to the wiki instructions for all-in-one, an extra disk is
    required:
      StarlingX/Installation_Guide_Virtual_Environment/Duplex

    Partial-Bug: #1793214

    Change-Id: I146c601493db6eab8871796b67061132cc6f4f30
    Signed-off-by: Michel Thebeau <email address hidden>

[Ghada Khalil (gkhalil)]

Marking as Fix Released. All required commits have merged.

I believe the reason the launchpad was not updated automatically is because there was an abandoned review:
https://review.openstack.org/603509
This was merged by another commit.