STX: Horizon admin, internal server error (AttributeError) attempting to create network

[Wendy Mitchell]

Brief Description
-----------------
STX: Horizon admin, internal server error attempting to create network

Severity
--------
Major

Steps to Reproduce
------------------
Login as Admin
Go to Admin > Network > Networks ie. .../admin/networks/
Select "Create Network"

Expected Behavior
------------------
admin user opens 'Create Network' dialog

Actual Behavior
----------------
admin user unable to open 'Create Network' dialog
Danger: An error occurred. Please try again later.

see error at the following times in the horizon.log
2018-09-18 15:23:54,506 [ERROR] django.request: Internal Server Error: /admin/networks/create/
Traceback

2018-09-18 15:23:54,506 [ERROR] django.request: Internal Server Error: /admin/networks/create/
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/decorators.py", line 52, in dec
    return view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/decorators.py", line 36, in dec
    return view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/decorators.py", line 84, in dec
    return view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/decorators.py", line 52, in dec
    return view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/decorators.py", line 36, in dec
    return view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/decorators.py", line 84, in dec
    return view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 71, in view
    return self.dispatch(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 89, in dispatch
    return handler(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/workflows/views.py", line 147, in get
    context = self.get_context_data(**kwargs)
  File "/usr/lib/python2.7/site-packages/horizon/workflows/views.py", line 92, in get_context_data
    workflow = self.get_workflow()
  File "/usr/lib/python2.7/site-packages/horizon/workflows/views.py", line 82, in get_workflow
    entry_point=entry_point)
  File "/usr/share/openstack-dashboard/openstack_dashboard/dashboards/admin/networks/workflows.py", line 68, in __init__
    request, *args, **kwargs)
  File "/usr/share/openstack-dashboard/openstack_dashboard/dashboards/admin/networks/forms.py", line 292, in __init__
    api.neutron.provider_network_type_list(request):
AttributeError: 'module' object has no attribute 'provider_network_type_list'

Reproducibility
---------------
Reproducible

System Configuration
--------------------
2 node

Branch/Pull Time/Commit
-----------------------
Master as of date: 2018-09-17_09-15-42

Timestamp/Logs
--------------
see above logs

[Kristine Bujold (kbujold)]

Proposed fix
https://github.com/starlingx-staging/stx-horizon/pull/14

[Kristine Bujold (kbujold)]

Fix with commit https://github.com/starlingx-staging/stx-horizon/commit/a2cdba4d72f9abd0db7f871b6830a292570f4563