AggregateProviderNetworkFilter should be restored to nova scheduling filters

[Gerry Kopec]

Brief Description
-----------------
When looking at nova scheduler filters for inclusion in helm/kubernetes overrides noticed that AggregateProviderNetworkFilter had been commented out in sysinv/puppet/nova.py in the first commit in stx-config:
https://github.com/openstack/stx-config/commit/9b95aa0a355d45cb2f78fb87cfa11fb09ee37e1d

It was recently delete by:
https://github.com/openstack/stx-config/commit/14d834d90abb1e032566300bcfaf663ae0819970
to cleanup a tox error.

This means that we are not checking during nova scheduling that a particular host is in the host aggregrates for the physical network(s) specified by the instance. Per discussion with Brent/Matt this should be added into the filters list.

Severity
--------
Minor

Steps to Reproduce
------------------
Launch instance and observe nova-scheduler.log

Expected Behavior
------------------
Should see log like this:
2018-09-13 19:49:43.898 9038 INFO nova.scheduler.filters.aggregate_provider_network_filter [req-20631684-bcde-43a3-88e8-1fbc34fe2d0c 5ce8db5995f847c1b06b2ee408b833e3 d01ba91e2aea41948bcb2c8773bdd3fc - default default] (compute-1, compute-1) PASS. provider:physical_network = [u'physnet1', u'physnet0']. require: [u'physnet0']

Actual Behavior
----------------
Above log not seen.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
all

Branch/Pull Time/Commit
-----------------------
stx-config, master see commits:
https://github.com/openstack/stx-config/commit/9b95aa0a355d45cb2f78fb87cfa11fb09ee37e1d
https://github.com/openstack/stx-config/commit/14d834d90abb1e032566300bcfaf663ae0819970

Timestamp/Logs
--------------
see above

[Ghada Khalil (gkhalil)]

Code removed from stx by mistake. Needs to be addressed for stx.2018.10

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/604646

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/604646
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=941e19ce64dcbb92e63ccedfed03ef92bf223dab
Submitter: Zuul
Branch: master

commit 941e19ce64dcbb92e63ccedfed03ef92bf223dab
Author: Daniel Chavolla <email address hidden>
Date: Sun Sep 23 12:59:49 2018 -0400

    Restore the Aggregate Provider Network Filter

    Restored AggregateProviderNetworkFilter to
    SCHEDULER_FILTERS_COMMON list as it was inadvertently
    removed by a previous commit.

    Closes bug 1792609

    Change-Id: Ia5bf0841145737a8196792e8ae23895741edfc39
    Signed-off-by: Daniel Chavolla <email address hidden>