Horizon internal server error on Project create network and create subnet

[Wendy Mitchell]

Title
-----------------
Project, Create Network and Create Subnet operations results in Internal Server Error

Brief Description
-----------------
In Horizon Project, Create Network and Create Subnet operations results in Internal Server Error

Severity
--------
Standard

Steps to Reproduce
------------------
1. As admin or tenant user
Log into Horizon
Navigate to Project - Network - Networks
Select "Create Network"

or alternatively select
Network - Network Topology - Graph tab "Create Network"

2. As admin or tenant user,
Log into Horizon
Navigate to Project - Network - Networks
Select one of the network and try to create a subnet
Subnets - "Create Subnet"

Expected Behavior
------------------
In previous releases "Create Network" would open the "Create Network" dialog (eg Network, Subnet, Subnet Details tabs)
In previous releases the "Create Subnet" would open the "Create Subnet" dialog (eg. Subnet, Subnet Details tabs))

Actual Behavior
----------------
Internal Server Error

Reproducibility
---------------
Reproducible

System Configuration
--------------------
2 controller system

Branch/Pull Time/Commit
-----------------------

Timestamp/Logs
--------------
see horizon.log

2018-09-11 17:30:27,343 [ERROR] horizon.workflows.base: Problem instantiating action class.
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/horizon/workflows/base.py", line 396, in action
    context)
  File "/usr/share/openstack-dashboard/openstack_dashboard/dashboards/project/networks/workflows.py", line 79, in __init__
    if api.base.is_stx_region(request):
  File "/usr/share/openstack-dashboard/openstack_dashboard/api/base.py", line 391, in is_stx_region
    if not base.is_service_enabled(request, 'platform'):
NameError: global name 'base' is not defined
2018-09-11 17:30:27,344 [ERROR] django.request: Internal Server Error: /project/networks/create

2018-09-11 17:31:42,738 [ERROR] horizon.workflows.base: Problem instantiating action class.
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/horizon/workflows/base.py", line 396, in action
    context)
  File "/usr/share/openstack-dashboard/openstack_dashboard/dashboards/project/networks/workflows.py", line 79, in __init__
    if api.base.is_stx_region(request):
  File "/usr/share/openstack-dashboard/openstack_dashboard/api/base.py", line 391, in is_stx_region
    if not base.is_service_enabled(request, 'platform'):
NameError: global name 'base' is not defined
2018-09-11 17:31:42,738 [ERROR] django.request: Internal Server Error: /project/network_topology/createnetwork

2018-09-11 17:43:35,031 [ERROR] horizon.workflows.base: Problem instantiating action class.
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/horizon/workflows/base.py", line 396, in action
    context)
  File "/usr/share/openstack-dashboard/openstack_dashboard/dashboards/project/networks/workflows.py", line 395, in __init__
    if not api.base.is_stx_region(request):
  File "/usr/share/openstack-dashboard/openstack_dashboard/api/base.py", line 391, in is_stx_region
    if not base.is_service_enabled(request, 'platform'):
NameError: global name 'base' is not defined
2018-09-11 17:43:35,032 [ERROR] django.request: Internal Server Error: /project/networks/510779f0-895a-4060-b5af-bcde9d71f3c1/subnets/create

[Frank Miller (sensfan22)]

Tagged as stx.2018.10 since Horizon panel plug-ins in stx-gui is a 2018.10 deliverable.

[Eddie Ramirez (ediardo)]

Same as https://bugs.launchpad.net/starlingx/+bug/1792151

[Eddie Ramirez (ediardo)]

This change goes stx-horizon side.

PR: https://github.com/starlingx-staging/stx-horizon/pull/8

[Dean Troyer (dtroyer)]

https://github.com/starlingx-staging/stx-horizon/pull/8 merged

[Ghada Khalil (gkhalil)]

Marking as Fix Released. The required commit is available in builds as of 2018-09-13