Horizon fails to change compute nova-local from remote to image

[Kristine Bujold]

Title
-----
Horizon fails to change compute nova-local from remote to image

Brief Description
-----------------
Horizon fails to change compute nova-local from remote to image, the same steps work on CLI

This is seen in sysinv.log
2018-09-12 15:28:13.481 2002 WARNING wsme.api [-] Client-side error: No disk with id bd07a765-b2a8-4729-890f-aa257935c263

[root@controller-0 sysinv(keystone_admin)]# system host-disk-partition-list compute-0
+--------------------------------------+-----------------------------+------------+--------------------------------------+-----------+----------+----------------------+
| uuid | device_path | device_nod | type_guid | type_name | size_gib | status |
| | | e | | | | |
+--------------------------------------+-----------------------------+------------+--------------------------------------+-----------+----------+----------------------+
| bd07a765-b2a8-4729-890f-aa257935c263 | /dev/disk/by-path/pci-0000: | /dev/sda6 | ba5eba11-0000-1111-2222-000000000001 | None | 4.0 | Creating (on unlock) |
| | 00:0d.0-ata-1.0-part6 | | | | | |
| | | | | | | |
+--------------------------------------+-----------------------------+------------+--------------------------------------+-----------+----------+----------------------+

[root@controller-0 sysinv(keystone_admin)]# system host-disk-partition-show compute-0 bd07a765-b2a8-4729-890f-aa257935c263
+-------------+--------------------------------------------------+
| Property | Value |
+-------------+--------------------------------------------------+
| device_path | /dev/disk/by-path/pci-0000:00:0d.0-ata-1.0-part6 |
| device_node | /dev/sda6 |
| type_guid | ba5eba11-0000-1111-2222-000000000001 |
| type_name | None |
| start_mib | None |
| end_mib | None |
| size_mib | 4096 |
| uuid | bd07a765-b2a8-4729-890f-aa257935c263 |
| ihost_uuid | 6cc779c8-384a-40f1-a575-3dda5371d6ab |
| idisk_uuid | 53453bf9-a340-456f-aca8-76801128335b |
| ipv_uuid | dde4caa1-8be9-4abb-98ad-8fc546cb43fd |
| status | Creating (on unlock) |
| created_at | 2018-09-11T20:45:12.692683+00:00 |
| updated_at | 2018-09-11T20:45:29.641818+00:00 |
+-------------+--------------------------------------------------+

Severity
--------
Minor

Steps to Reproduce
------------------
- Lock compute-x
- Go to Admin/Platform/Host Inventory/compute-0/ Local Volume Groups/nova-local/
- Change the "Instance Backing" from image to remote
- Delete nova-local
- Add nova-local
- Change the "Instance Backing" from remote to image

This fails in Horizon but can be done on the CLI with

system host-lvg-delete compute-0 7c7bc224-7bde-4461-9277-2a6db19c7cda
system host-lvg-add compute-0 nova-local
system host-lvg-modify -b image compute-0 nova-local

Expected Behavior
------------------
Should be able to change the instance backing back to image

Actual Behavior
----------------
The image backing cannot be changed in Horizon once its set to remote

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Storage

Branch/Pull Time/Commit
-----------------------
stx-gui 41e8acd43eb8377799ef9178712b0c2f7b3e235d

Timestamp/Logs
--------------

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/604903

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/604903
Committed: https://git.openstack.org/cgit/openstack/stx-gui/commit/?id=62ac18051df6112035044fc9d139b7b31e94e2bf
Submitter: Zuul
Branch: master

commit 62ac18051df6112035044fc9d139b7b31e94e2bf
Author: Kristine Bujold <email address hidden>
Date: Mon Sep 24 16:28:59 2018 -0400

    Cannot change instance backing from lvm to image

    A float was being passed in for "Instances Logical Volume Size" and the
    form field is an integer. The field was hidden on image backing edits
    and thus the user could not see the error.

    Closes-Bug: 1791998

    Change-Id: Ia1f34845a5c01d269c511f707a7f1022ec461a35
    Signed-off-by: Kristine Bujold <email address hidden>