Alarm does not clear after changing https mode

[Paul-Emile Element]

Brief Description
-----------------

When switching frpm http to https mode or back, the "configuration is out-of-date" alarm will sometime fail to clear and remain set indefinitely

Severity
--------
Minor

Steps to Reproduce
------------------
1. system modify --https_enabled="true"'
2. wait for configuration out-of-date alarms to set and clear on both controllers, and check openstack endpoint list are using https for public endpoints
4. system modify --https_enabled="false"'
5. check alarms and endpoints

Expected Behavior
------------------
The "configuration is out-of-date" alarm is set on controller(s), and cleared when the operation is complete

Actual Behavior
----------------
In some case, the operation completes as expected, but the alarm is not cleared

Reproducibility
---------------
Intermittent

System Configuration
--------------------
Any system configuration

Branch/Pull Time/Commit
-----------------------
Mater branch, initial commit

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/601619

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/601619
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=5998f072ea0c431f593b867338c6885ea74d708d
Submitter: Zuul
Branch: master

commit 5998f072ea0c431f593b867338c6885ea74d708d
Author: Paul-Emile Element <email address hidden>
Date: Tue Sep 11 11:28:25 2018 -0400

    synchronize file update in sysinv agent

    This modification adds a synchronization decorator to the
    file update function of the sysinv agent.
    This will ensure that the operation does not happen
    concurrently with the 'runtime manifest apply' or the
    'agent audit' function.
    Otherwise, a race condition may happen and cause
    manifest corruption or failure to properly handle alarms.

    Closes-Bug: #1791969

    Change-Id: If9b6baf1608850bad0e3830ebe8345f7dc68ef62
    Signed-off-by: Paul-Emile Element <email address hidden>

[mhg (marvinhg)]

Retest passed on load 2018-09-13_20-18-01.
After enabled HTTPS, all endpoints are showing with HTTPS.

[mhg (marvinhg)]

And also active alarms of "controller-x Configuration is out-of-date" were cleared after HTTPS enabled.