cleanup: build scripts contain hardcoded server names

Bug #1791343 reported by Paul-Emile Element
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Paul-Emile Element

Bug Description

Title
-----
Build scripts contain hardcoded internal server names

Brief Description
-----------------
The initial version of some build scripts included hardcoded server names are not relevant
outside of the environment were they were originally created and tested.
This does not cause any build or runtime problem.

the scripts are under the build-tools directory :

 sign-rpms
        sign-secure-boot
        sign_iso_formal.sh
        sign_patch_formal.sh

Severity
--------
<Minor: System/Feature is usable with minor issue>

Steps to Reproduce
------------------
The problem has been identified during code inspections.

Expected Behavior
------------------
The code should not contain references to resources that are not publicly visible and usable

Actual Behavior
----------------

Reproducibility
---------------
<Reproducible/Intermittent>
N/A

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
This problem existed in the original code submission.

Timestamp/Logs
--------------
N/A

Changed in starlingx:
assignee: nobody → Paul-Emile Element (paul-emileelement)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-root (master)

Fix proposed to branch: master
Review: https://review.openstack.org/600821

Changed in starlingx:
status: New → In Progress
Ghada Khalil (gkhalil)
tags: added: stx.build
tags: added: stx.2018.10
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-root (master)

Reviewed: https://review.openstack.org/600821
Committed: https://git.openstack.org/cgit/openstack/stx-root/commit/?id=2f9d9a5672a5c2cda7375d5efa747beef55675b9
Submitter: Zuul
Branch: master

commit 2f9d9a5672a5c2cda7375d5efa747beef55675b9
Author: Paul-Emile Element <email address hidden>
Date: Fri Sep 7 13:09:07 2018 -0400

    cleanup signing scripts

    the scripts contained hardcoded references to resources
    that are not visible outside of the environment
    where the scripts were originally created and used

    The scripts sign-rpms was also updated with the original version
    that was intended to be submitted. The initial submission contained
    the wrong version.

    Closes-Bug: #1791343

    Change-Id: I8ce5884ad75156d3730cf30a451051d32445e136
    Signed-off-by: Paul-Emile Element <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-root (f/centos75)

Fix proposed to branch: f/centos75
Review: https://review.openstack.org/602657

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-root (centos75)

Fix proposed to branch: centos75
Review: https://review.openstack.org/602660

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-root (f/centos75)

Reviewed: https://review.openstack.org/602657
Committed: https://git.openstack.org/cgit/openstack/stx-root/commit/?id=21bcc109554495a620dd8475a3a796598bb106eb
Submitter: Zuul
Branch: f/centos75

commit 2f9d9a5672a5c2cda7375d5efa747beef55675b9
Author: Paul-Emile Element <email address hidden>
Date: Fri Sep 7 13:09:07 2018 -0400

    cleanup signing scripts

    the scripts contained hardcoded references to resources
    that are not visible outside of the environment
    where the scripts were originally created and used

    The scripts sign-rpms was also updated with the original version
    that was intended to be submitted. The initial submission contained
    the wrong version.

    Closes-Bug: #1791343

    Change-Id: I8ce5884ad75156d3730cf30a451051d32445e136
    Signed-off-by: Paul-Emile Element <email address hidden>

tags: added: in-f-centos75
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on stx-root (centos75)

Change abandoned by Dean Troyer (<email address hidden>) on branch: centos75
Review: https://review.openstack.org/602660

Ken Young (kenyis)
tags: added: stx.1.0
removed: stx.2018.10
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.