Distributed Cloud: config_subcloud fails due to manifest errors

[Tao Liu]

Brief Description
-----------------
The config_subcloud command fails due to the ceilometer manifest errors listed below:

2018-09-07T00:32:12.492 ^[[0;36mDebug: 2018-09-07 00:32:12 +0000
Exec[ceilometer-upgrade](provider=posix): Executing check 'test true = true'^[[0m
2018-09-07T00:32:12.494 ^[[0;36mDebug: 2018-09-07 00:32:12 +0000 Executing with uid=ceilometer: 'test true = true'^[[0m
2018-09-07T00:32:12.505 ^[[0;36mDebug: 2018-09-07 00:32:12 +0000
/Stage[main]/Ceilometer::Db::Sync/Exec[ceilometer-upgrade]/returns: Exec try 1/10^[[0m
2018-09-07T00:32:12.507 ^[[0;36mDebug: 2018-09-07 00:32:12 +0000
Exec[ceilometer-upgrade](provider=posix): Executing 'ceilometer-upgrade --skip-metering-database'^[[0m
2018-09-07T00:32:12.510 ^[[0;36mDebug: 2018-09-07 00:32:12 +0000 Executing with uid=ceilometer: 'ceilometer-upgrade --skip-metering-database'^[[0m
2018-09-07T00:32:13.652 ^[[0;36mDebug: 2018-09-07 00:32:13 +0000
/Stage[main]/Ceilometer::Db::Sync/Exec[ceilometer-upgrade]/returns:
Sleeping for 5 seconds between tries^[[0m
2018-09-07T00:32:18.653 ^[[0;36mDebug: 2018-09-07 00:32:18 +0000
/Stage[main]/Ceilometer::Db::Sync/Exec[ceilometer-upgrade]/returns: Exec try 2/10^[[0m
2018-09-07T00:32:18.657 ^[[0;36mDebug: 2018-09-07 00:32:18 +0000
Exec[ceilometer-upgrade](provider=posix): Executing 'ceilometer-upgrade --skip-metering-database'^[[0m
2018-09-07T00:32:18.659 ^[[0;36mDebug: 2018-09-07 00:32:18 +0000 Executing with uid=ceilometer: 'ceilometer-upgrade --skip-metering-database'^[[0m
2018-09-07T00:32:19.764 ^[[0;36mDebug: 2018-09-07 00:32:19 +0000
/Stage[main]/Ceilometer::Db::Sync/Exec[ceilometer-upgrade]/returns:
Sleeping for 5 seconds between tries^[[0m

Severity
--------
Critical

Steps to Reproduce
------------------
Install a Distributed Cloud system, add a subcloud on the system controller and run config_subcloud on the subcloud system

Expected Behavior
------------------
The subcloud is configured successfully

Actual Behavior
----------------
Fail to configure a subcloud

Reproducibility
---------------
Always

System Configuration
--------------------
2 System Controllers and 1 One node system

Branch/Pull Time/Commit
-----------------------
master

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/600865

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/600865
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=d035cfabe58f8dcbd42e0938292865bb76a3c616
Submitter: Zuul
Branch: master

commit d035cfabe58f8dcbd42e0938292865bb76a3c616
Author: Angie Wang <email address hidden>
Date: Fri Sep 7 16:32:37 2018 -0400

    Update puppet ceilometer upgrade dependency on service identity

    The existing dependency for ceilometer upgrade cannot ensure that it
    was executed after all service identites for ceilometer and gnocchi
    were created. This causes ceilometer upgrade fails during subcloud
    configuration since an ordering problem that ceilometer service not
    being created before running ceilometer upgrade.
    This commit is to update the dependency against the service identity
    for ceilometer and gnocchi to ensure the correct ordering.

    Closes-Bug: 1791303

    Change-Id: Ibb4fb0fe15ba5c046d3c03478e4a9c1bee908f35
    Signed-off-by: Angie Wang <email address hidden>