Controllers with small disks have issues adding new filesystems

[Frank Miller]

Brief Description
-----------------
The default controller filesystem sizes are based on the underlying root disk size and currently targets a virtual disk and varying disk sizes (<120GB). The current small disk size is a lab specific restriction and is problematic when adding new file system since there is insufficient room to support all file systems. To simplify future changes the checks should be based on a small disk size (not virtual or physical) of only consider small disks that are <240GB or large disks (>240GB). This will simplify the logic to support the new lab restriction of disks that are 240GB and our standard deployment requirement of >500GB.

Severity
--------
Minor

Steps to Reproduce
------------------
n/a

Expected Behavior
------------------
It should be easy to add a new filesystem even on smaller disks

Actual Behavior
----------------
Sometimes the system prevents adding a new filesystem on smaller disks even when there is room.

Reproducibility
---------------
Reproducible on labs with smaller disks or on a virtual environment.

System Configuration
--------------------
Any system config where the controller is using a small disk

Branch/Pull Time/Commit
-----------------------
n/a

Timestamp/Logs
--------------
n/a

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/600743

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/600745

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/600743
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=92cc2240cfbdb99c249c229b94568723d8b86897
Submitter: Zuul
Branch: master

commit 92cc2240cfbdb99c249c229b94568723d8b86897
Author: Stefan Dinescu <email address hidden>
Date: Fri Sep 7 15:44:49 2018 +0300

    Simplify disk space allocation

    Allocating of space on the root disk was done in kickstart, combined
    with config_controller. Various checks for disk and volume group
    space made it difficult to add new filesystem partitions.

    To simplify this, all checks are now merged under disk size checks.

    Kickstart files now create the partitions of the same size for
    rootfs and log partitions, no matter the disk size, with the
    only variable size being the cgts-vg size.

    Thus, any future changes will only need to consider only this
    size for ensuring enough space is present.

    The limit between small and big disks is 240GB, with a minimum
    disk size of 120GB.

    Change-Id: I0ac54d5b2ba72af9505881c5849bc4e76540b3f4
    Closes-bug: 1791170
    Signed-off-by: Stefan Dinescu <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/600745
Committed: https://git.openstack.org/cgit/openstack/stx-metal/commit/?id=103cccd786ce0a3ec6e5df421b11739469a97db4
Submitter: Zuul
Branch: master

commit 103cccd786ce0a3ec6e5df421b11739469a97db4
Author: Stefan Dinescu <email address hidden>
Date: Fri Sep 7 15:56:12 2018 +0300

    Simplify disk space allocation

    Allocating of space on the root disk was done in kickstart, combined
    with config_controller. Various checks for disk and volume group
    space made it difficult to add new filesystem partitions.

    To simplify this, all checks are now merged under disk size checks.

    Kickstart files now create the partitions of the same size for
    rootfs and log partitions, no matter the disk size, with the
    only variable size being the cgts-vg size.

    Thus, any future changes will only need to consider only this
    size for ensuring enough space is present.

    The limit between small and big disks is 240GB, with a minimum
    disk size of 120GB.

    Depends-On: https://review.openstack.org/#/c/600743/
    Change-Id: I37ecc8eb5468811d1ca3a71f8e2a0629525e8fad
    Closes-bug: 1791170
    Signed-off-by: Stefan Dinescu <email address hidden>