openstack port create cli rejected when using --wrs-binding argument

[Senthil Mukundakumar]

Brief Description
----------------------
Openstack port create cli command does not recognize --wrs-binding parameter.

Severity
--------
Minor

Steps to Reproduce
------------------
1. Use openstack command to create port
[wrsroot@controller-0 ~(keystone_admin)]$ openstack port create --network 9ef5cfdf-940e-49fb-9fcd-80b1dd5b059d --wrs-binding:vif_model virtio vrf10
usage: openstack port create [-h] [-f {json,shell,table,value,yaml}]
                             [-c COLUMN] [--max-width <integer>] [--fit-width]
                             [--print-empty] [--noindent] [--prefix PREFIX]
                             --network <network> [--description <description>]
                             [--device <device-id>]
                             [--mac-address <mac-address>]
                             [--device-owner <device-owner>]
                             [--vnic-type <vnic-type>] [--host <host-id>]
                             [--dns-name dns-name]
                             [--fixed-ip subnet=<subnet>,ip-address=<ip-address>]
                             [--binding-profile <binding-profile>]
                             [--enable | --disable] [--project <project>]
                             [--project-domain <project-domain>]
                             [--security-group <security-group> | --no-security-group]
                             [--qos-policy <qos-policy>]
                             [--enable-port-security | --disable-port-security]
                             [--allowed-address ip-address=<ip-address>[,mac-address=<mac-address>]]
                             [--tag <tag> | --no-tag]
                             <name>
openstack port create: error: unrecognized arguments: --wrs-binding:vif_model vrf10

Expected Behavior
------------------
port should be created

Actual Behavior
----------------
openstack port create: error: unrecognized arguments: --wrs-binding:vif_model vrf10

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Any

Branch/Pull Time/Commit
-----------------------
StarlingX master as of 2018-08-31_20-18-00

Work Around:
-------------------
Use neutron command
[wrsroot@controller-0 ~(keystone_admin)]$ neutron port-create --wrs-binding:vif_model virtio --name vrf10 9ef5cfdf-940e-49fb-9fcd-80b1dd5b059d
neutron CLI is deprecated and will be removed in the future. Use openstack CLI instead.
Created a new port:
+---------------------------+----------------------------------------------------------------------------------+
| Field | Value |
+---------------------------+----------------------------------------------------------------------------------+
| admin_state_up | True |
| allowed_address_pairs | |
| binding:host_id | |
| binding:profile | {} |
| binding:vif_details | {} |
| binding:vif_type | unbound |
| binding:vnic_type | normal |
| created_at | 2018-09-06T18:15:46Z |
| description | |
| device_id | |
| device_owner | |
| extra_dhcp_opts | |
| fixed_ips | {"subnet_id": "84e8c4fd-478b-41c6-bf8a-9de755592bf9", "ip_address": "30.0.0.12"} |
| id | 71b686a0-d7fe-4816-92ae-4c81ede2cd96 |
| mac_address | fa:16:3e:ba:e6:4e |
| name | vrf10 |
| network_id | 9ef5cfdf-940e-49fb-9fcd-80b1dd5b059d |
| project_id | 6782b335bc9d48929b7d1c839d865ad0 |
| revision_number | 2 |
| security_groups | |
| status | DOWN |
| tags | |
| tenant_id | 6782b335bc9d48929b7d1c839d865ad0 |
| updated_at | 2018-09-06T18:15:46Z |
| wrs-binding:mac_filtering | False |
| wrs-binding:mtu | 1500 |
| wrs-binding:vif_model | virtio |
+---------------------------+----------------------------------------------------------------------------------+

[wrsroot@controller-0 ~(keystone_admin)]$

============================================

[Ghada Khalil (gkhalil)]

This command was missed when the openstack client was updated to support the starlingx custom extensions. This should be straight-forward to fix this by adding a patch to
https://git.openstack.org/cgit/openstack/stx-upstream/tree/openstack/python-openstackclient/centos/patches

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/605236

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/605236
Committed: https://git.openstack.org/cgit/openstack/stx-upstream/commit/?id=995ced9e78d15a6d2459215a28a9d950cdd8637a
Submitter: Zuul
Branch: master

commit 995ced9e78d15a6d2459215a28a9d950cdd8637a
Author: Joseph Richard <email address hidden>
Date: Tue Sep 25 14:59:36 2018 -0400

    Allow setting wrs-binding:vif_model using osclient

    This commit adds support for setting wrs-binding:vif_model using
    osclient.
    The syntax is openstack port create --wrs-binding:vif_model VIF_MODEL.

    Change-Id: Ifb0abe0a02c382535b0073effc66d04ad38816eb
    Closes-Bug: 1791127
    Signed-off-by: Joseph Richard <email address hidden>