build-srpms-serial is broken

[Austin Sun]

Brief Description
-----------------
The build-srpms-serial can not generate srpms. The SRPMs are generated , but due to Audit obsolete srpms bug , all srpms were wrongly audit/delete.

Severity
--------
Major

Steps to Reproduce
------------------
run build-pkgs --serial command when do build system

Expected Behavior
------------------
The srpms are not deleted

Actual Behavior
----------------
The srpms are deleted

Reproducibility
---------------
if do a clean build , this will 100% reproducible

System Configuration
--------------------
<One node system, Two node system, Multi-node system, Dedicated storage, https, IPv4, IPv6 etc.>

Branch/Pull Time/Commit
-----------------------
found in 58b942baf160da02171b985071f0b8ef4531698f
Change-Id: I5009b8a360bdb4a03e5a4e83430b7f2ef135115e

Timestamp/Logs
--------------
######## Fri Aug 31 07:51:23 UTC 2018: Launching build-rpms-serial --std

/localdisk/designer/sunausti/stx_0831/cgcs-root/build-tools/build-rpms-serial --std
FORMAL_BUILD=0
modify-build-cfg /localdisk/loadbuild/sunausti/stx_0831/std/sunausti-stx_0831-tis-r5-pike-std.cfg
Nothing to build in '/localdisk/loadbuild/sunausti/stx_0831/std/rpmbuild/SRPMS'

######## Fri Aug 31 07:51:24 UTC 2018: build-rpm-serial --std was successful

[Ghada Khalil (gkhalil)]

Gerrit review in progress:
https://review.openstack.org/#/c/599513/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/599513
Committed: https://git.openstack.org/cgit/openstack/stx-root/commit/?id=90d75a655dfa815128e5ed628858a0335f101bc0
Submitter: Zuul
Branch: master

commit 90d75a655dfa815128e5ed628858a0335f101bc0
Author: Sun Austin <email address hidden>
Date: Tue Sep 4 15:42:51 2018 +0800

    Fix build-srpms-serial audit all srpms issue

      -The srpms are deleted wrongly due to audit bug
      -adding cleanup function call when exiting script

    Closes-Bug: 1790583

    Change-Id: I45016ec6ac1343f0188eecfd71aa4e3dff2c8119
    Signed-off-by: Sun Austin <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/603983

[Ghada Khalil (gkhalil)]

Re-opening the bug. It appears a new commit is required.

[Erich Cordoba (ericho)]

After a git bisect, it seems that the issue was introduced here:

b0bcb59c15c48456c41b5bffe917b6a4b7854f2b is the first bad commit
commit b0bcb59c15c48456c41b5bffe917b6a4b7854f2b
Author: Scott Little <email address hidden>
Date: Wed Aug 29 16:04:16 2018 -0400

    Build: Improved logging, error handling, and other small fixes

    Add function and line number to error logs.

    Log git commands that are issured when using --edit.

    Replace global DIR variable with a more unique variable name.
    DIR is used in many scripts that get sourced, possibly overwriting
    the value in the calling script.

    Make sure scripts won't fail if a redundant --parallel or --serial
    argurement is seen.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/603983
Committed: https://git.openstack.org/cgit/openstack/stx-root/commit/?id=a70cf675a5cf19f796ed967ad409d09c799e1d1b
Submitter: Zuul
Branch: master

commit a70cf675a5cf19f796ed967ad409d09c799e1d1b
Author: Sun Austin <email address hidden>
Date: Thu Sep 20 10:16:56 2018 +0800

    Fix build-srpms-serial audit all srpms issue

      -The srpms are deleted wrongly due to audit bug
      -adding cleanup function call when exiting script

    Closes-Bug: 1790583

    Change-Id: I82fdbabc74330c68fbd6b2635e1e563b5b7656c2
    Signed-off-by: Sun Austin <email address hidden>

[Ghada Khalil (gkhalil)]

This commit is also required to address this issue:
https://review.openstack.org/#/c/605578/