sysinv rest API health query failed

[Yang Liu]

Brief Description
-----------------
'health' resource is listed for sysinv api; however, querying it fails with error "Unable to perform health query."

Severity
--------
Minor

Steps to Reproduce
------------------
1. Check resources listed for sysinv api:
curl -i -X GET http://128.224.151.94:6385/v1/ -H "Content-Type: application/json" -H "X-Auth-Token: gAAAAABbhC4ZG5PuqJ2DUL6QoWHTG4OsZW8regVXDhyDSGPWxfmgsmHBJN84BQfh_vz2rTsKjAqmkdnw_1mIQx2hBajbDWzcmRPd0hpCtkNKdntp0up0z5OH6IzBZvSF6MgWGZT-wOYJk8SbHjqO4Z_hOTxyE89oW5Trd7_ypZO29vI5BKnqtDg"; echo ''
.... "health": [{"href": "http://128.224.151.94:6385/v1/health/", "rel": "self"}, {"href": "http://128.224.151.94:6385/health/", "rel": "bookmark"}]....

2. Attempt to query system health:
curl -i -X GET http://128.224.151.94:6385/v1/health -H "Content-Type: application/json" -H "X-Auth-Token: gAAAAABbhC4ZG5PuqJ2DUL6QoWHTG4OsZW8regVXDhyDSGPWxfmgsmHBJN84BQfh_vz2rTsKjAqmkdnw_1mIQx2hBajbDWzcmRPd0hpCtkNKdntp0up0z5OH6IzBZvSF6MgWGZT-wOYJk8SbHjqO4Z_hOTxyE89oW5Trd7_ypZO29vI5BKnqtDg"; echo ''

Expected Behavior
------------------
2.
All hosts are provisioned: [OK]
All hosts are unlocked/enabled: [OK]
All hosts have current configurations: [OK]
All hosts are patch current: [OK]
No alarms: [Fail]
[1] alarms found, [0] of which are management affecting

Actual Behavior
----------------
2.
HTTP/1.1 400 Bad Request
Content-Type: application/json
Content-Length: 123
Date: Mon, 27 Aug 2018 17:18:29 GMT

{"error_message": "{\"debuginfo\": null, \"faultcode\": \"Client\", \"faultstring\": \"Unable to perform health query.\"}"}

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Any

Branch/Pull Time/Commit
-----------------------
StarlingX master as of 2018-08-24_11-22-14

[Ghada Khalil (gkhalil)]

Marked as gating for stx.2019.03. Appears to be a minor issue affecting a specific REST API call.

[Ghada Khalil (gkhalil)]

Given that this was introduced by the stx-fault de-coupling, Tao is planning to fix this issue for stx.2018.03; updating the target release accordingly.

[Ghada Khalil (gkhalil)]

correction: This is now targeted for the stx.2018.10 release

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/602163

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/602163
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=a8acc56242a8d08f1894a09d66afad2d7bd4fae7
Submitter: Zuul
Branch: master

commit a8acc56242a8d08f1894a09d66afad2d7bd4fae7
Author: Tao Liu <email address hidden>
Date: Wed Sep 12 16:44:37 2018 -0400

    Sysinv healthy query API request failed

    The healthy query API request triggers sysinv to query the alarm list.
    The alarm query is attempted via a sysinv database API which is no
    longer supported. This results in the REST API request failure.

    This update contains the following changes to address the issue:
    1.Add FM catalog info to sysinv puppet class and manifest
    2.Add service catalog to the user request context
    3.Add a FM client interface to communicate with FM API
    4.Update the health query to retrieve the alarm list via FM client

    Closes-Bug: # 1789983

    Change-Id: I31b256f6de22fe70cba59b08bf927c8b0ac119ee
    Signed-off-by: Tao Liu <email address hidden>