compute_reserved.conf does not set values for ovs-dpdk

[Ghada Khalil]

Brief Description
-----------------
The /etc/nova/compute_reserved.conf is not updated by the generic platform module compute.pp manifest. This results in some of the values not being set properly for ovs-dpdk in starlingx.

The compute_reserved.conf should be converted into a ERB template with the following values updated based on the host configuration values.

All compute_reserved_config attributes values of puppet-cgcs_vswitch and the corresponding provider need to be removed and added to compute.pp.

This also requires changes to the hiera data generation in the avs.py sysinv puppet plugin to move the setting of the values to platform.py.

These values should be populated for ovs-dpdk. Although not all parameters are consumed since some are only used by the nova monitors. However, in general it makes more sense for compute_reserved.conf to be managed by the compute.pp manifest.

Severity
--------
Major

Steps to Reproduce
------------------
Bring up compute node with starlingx
Verify the compute_reserved values

Expected Behavior
------------------
Values are set for ovs-dpdk

Actual Behavior
----------------
Values are not set

Reproducibility
---------------
100% Reproducible

System Configuration
--------------------
Multi-node system

Branch/Pull Time/Commit
-----------------------
master as of 2018-08-07

Timestamp/Logs
--------------
N/A

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/601642

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/601642
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=a272143739bc9443fb034e8d76fb6452243baa91
Submitter: Zuul
Branch: master

commit a272143739bc9443fb034e8d76fb6452243baa91
Author: Tao Liu <email address hidden>
Date: Tue Sep 11 13:07:35 2018 -0400

    Update compute_reserved.conf via a platform manifest

    The /etc/nova/compute_reserved.conf is not updated by the generic
    platform module compute.pp manifest. This results in some of the
    values not being set properly for ovs-dpdk in starlingx.

    This update creates an ERB template for compute_reserved.conf
    and manages the ERB template through the platform compute.pp
    manifest.

    In addition, the hiera data generation has been added to sysinv
    puppet platform operator.

    Closes-Bug: #1789726

    Change-Id: I3a005482342532229c66b5bd9f36d581a85d30f7
    Signed-off-by: Tao Liu <email address hidden>