Modifying ae mode for oam interface of controller-1 doesn't take effect

[Ghada Khalil]

Brief Description
-----------------
Modifying the ae mode for the oam interface on contoller-1 does not take effect.
As a workaround, deleting/recreating the ae interface and unlocking controller-1 fixes the configuration.

Severity
--------
Minor

Steps to Reproduce
------------------
- Modify ae mode on controller-1 oam interface from active/standby to 802.3ad
- Lock/Unlock controller-1

Expected Behavior
------------------
ae mode is changed to 802.3ad

Actual Behavior
----------------
ae mode is not changed (see output below)

Reproducibility
---------------
100% Reproducible

System Configuration
--------------------
Multi-node systems

Branch/Pull Time/Commit
-----------------------
master as of 2018-08-27_20-18-00

Timestamp/Logs
--------------
controller-1:~$ cat /proc/net/bonding/bond1
Ethernet Channel Bonding Driver: v3.7.1 (April 27, 2011)

Bonding Mode: fault-tolerance (active-backup)
Primary Slave: eno3 (primary_reselect always)
Currently Active Slave: eno3
MII Status: up
MII Polling Interval (ms): 100
Up Delay (ms): 0
Down Delay (ms): 0

Slave Interface: eno3
MII Status: up
Speed: 1000 Mbps
Duplex: full
Link Failure Count: 0
Permanent HW addr: 94:18:82:89:db:06
Slave queue ID: 0

Slave Interface: eno4
MII Status: up
Speed: 1000 Mbps
Duplex: full
Link Failure Count: 0
Permanent HW addr: 94:18:82:89:db:07
Slave queue ID: 0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/597701

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/597701
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=428e69776c9c02cb38234a8f0dfc5c0e1b4d1d32
Submitter: Zuul
Branch: master

commit 428e69776c9c02cb38234a8f0dfc5c0e1b4d1d32
Author: Joseph Richard <email address hidden>
Date: Mon Aug 27 14:37:11 2018 -0400

    Detect BONDING_OPTS when applying network config

    This commit adds BONDING_OPTS to the list of attributes to check for
    changes when applying network config.

    This commit also adds BONDING_OPTS as a special case inside of
    normalized_cfg_attr_value. This is necessary becase The BONDING_OPTS
    attribute contains '=' characters, so is not correctly parsed by
    splitting on '=' as done for other attributes. Because this is only
    being used to check for changes to BONDING_OPTS, rather than actually
    using the returned value, this will return the whole line for
    BONDING_OPTS.

    Closes-Bug: 1789444
    Change-Id: I01d1ef2bc80093d41fe95b68e4abdc309b574d47
    Signed-off-by: Joseph Richard <email address hidden>