Incorrect log flooding when standby controller is failed

[Ghada Khalil]

Brief Description
-----------------
When the standby controller is in a failed state (e.g. power off), SM continuously generates the following log on the active controller:
2018-08-17T18:59:28.000 controller-1 sm: debug time[274743.177] log<159247> INFO: sm[2054]: sm_service_domain_filter.c(325): Uncontrolled swact start

This log is incorrect/confusing as there isn't an uncontrolled swact, since the failed controller is standby. The log is generated every few seconds.

Steps to Reproduce
------------------
Power Off the standby controller.
Check the SM logs under /var/log on the active controller.

Expected Behavior
------------------
No log flooding

Actual Behavior
----------------
The above log is generated every few seconds while the standby controller is in a failed state

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
System with two controllers

Branch/Pull Time/Commit
-----------------------
master

Timestamp/Logs
--------------
N/A

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/596305

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/596305
Committed: https://git.openstack.org/cgit/openstack/stx-ha/commit/?id=53a055cb3aeed9ddb0368f65e26932d044162136
Submitter: Zuul
Branch: master

commit 53a055cb3aeed9ddb0368f65e26932d044162136
Author: Bin Qian <email address hidden>
Date: Thu Aug 23 14:06:48 2018 -0400

    remove incorrect logging when standby controller failed

    Add condition for the logging so to log only when the active controller
    failure which triggers a uncontrollered swact.
    The following changes are made:
    1. move get_controller_state to a new sm_failover_utils.c and renamed it
       to sm_get_controller_state.
    2. use the above function to check ensure to log only when the controller
       schedulering state is changing (swact).

    Closes-Bug: 1788697

    Change-Id: I145b579c2d31e8c9e184894774d3a1c06c9149d7
    Signed-off-by: Bin Qian <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/597541

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/597541
Committed: https://git.openstack.org/cgit/openstack/stx-ha/commit/?id=1d6df43950fd79688988fab83ee61ea6b00af83b
Submitter: Zuul
Branch: master

commit 1d6df43950fd79688988fab83ee61ea6b00af83b
Author: Bin Qian <email address hidden>
Date: Wed Aug 29 10:19:58 2018 -0400

    remove incorrect logging when standby controller failed

    Fixed the previous commit that returns from a failure situation
    withouth finalizing the scheduling.

    Closes-Bug: 1788697

    Change-Id: I8d80e4938067df13ccbd36b886f20c5359c39eac
    Signed-off-by: Bin Qian <email address hidden>