Current trunk does not build : parser-generated code causes issue

[Mike]

A fresh checkout of trunk currently does not build:

After doing a
 ant buildparser

I build with
 ant

The following output occurs:

[lpmike@dredd trunk]$ ant
Buildfile: /home/lpmike/workspace/stado/tmp/trunk/build.xml

all:

prepare:
    [mkdir] Created dir: /home/lpmike/workspace/stado/tmp/trunk/build
    [mkdir] Created dir: /home/lpmike/workspace/stado/tmp/trunk/jars
    [mkdir] Created dir: /home/lpmike/workspace/stado/tmp/trunk/dist

compile:
    [javac] Compiling 123 source files to /home/lpmike/workspace/stado/tmp/trunk/build
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] Compiling 960 source files to /home/lpmike/workspace/stado/tmp/trunk/build
    [javac] /home/lpmike/workspace/stado/tmp/trunk/src/org/postgresql/stado/parser/core/CSQLParserTokenManager.java:11476: code too large for try statement
    [javac] catch(java.io.IOException e) { return curPos; }
    [javac] ^
    [javac] /home/lpmike/workspace/stado/tmp/trunk/src/org/postgresql/stado/parser/core/CSQLParserTokenManager.java:5082: code too large
    [javac] private final int jjMoveNfa_0(int startState, int curPos)
    [javac] ^
    [javac] Note: /home/lpmike/workspace/stado/tmp/trunk/src/org/postgresql/stado/misc/combinedresultset/ServerResultSetImpl.java uses or overrides a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 2 errors

BUILD FAILED
/home/lpmike/workspace/stado/tmp/trunk/build.xml:42: The following error occurred while executing this line:
/home/lpmike/workspace/stado/tmp/trunk/build.xml:71: Compile failed; see the compiler error output for details.

Total time: 35 seconds

The problem seems to stem from the fix applied for TIMESTAMP WITH TIME ZONE bug #872215

https://bugs.launchpad.net/stado/+bug/872215

Once I removed the TIMESTAMP WITH TIMEZONE parsing changes, I was able to build again.

[Jim Mlodgenski (jim-cirrusql)]

What version of the JDK are you using? The Stado grammar is right on the edge of where the file produced by javacc is larger than the 64K limit of Java.

[Mike (s-launchpadmike)]

Hey Jim, thanks for the quick response as always :)

We're using openJDK 1.6.0 with javac 1.6.0_17

[Mike (s-launchpadmike)]

Oh, and we're using the javacc that ships with the stado source, I think its javacc 4.

[Jim Mlodgenski (jim-cirrusql)]

Patch attached. I will commit this to the trunk. I think based on this we should consider upgrading JTB to 1.3.2 which seems to create more compact grammar files.

[Mike (s-launchpadmike)]

Thats great, thanks Jim!