Use stestr instead of testrepository

Bug #1735667 reported by Masayuki Igawa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StackViz
Fix Released
Undecided
Unassigned

Bug Description

We are now starting to use stestr instead of testrepository. But in stackviz, there are some code depend on the testrepository.

So, I think it's better to migrate the code to use stestr.

Masayuki Igawa (igawa)
description: updated
Revision history for this message
chandan kumar (chkumar246) wrote :

I think we can keep both testrepository as well as stestr as projects having stable branches they uses testr. so it will help not to break anything.

Changed in stackviz:
status: New → Confirmed
Revision history for this message
Andrea Frittoli (andrea-frittoli) wrote :

This is not an issue for new style jobs that use the ansible role: https://github.com/openstack/tempest/blob/master/roles/process-stackviz/tasks/main.yaml#L12, since it uses subunit directly, and the role that produces subunit accounts for both testr and stestr: https://github.com/openstack-infra/zuul-jobs/blob/master/roles/process-test-results/tasks/main.yaml

Revision history for this message
Martin Kopec (mkopec) wrote :

I think this got partially addressed by: https://review.opendev.org/c/openstack/stackviz/+/656708

Also as of today, I still see 'testrepository' occurrence in the code:
[master]$ grep -r testrepository .
./doc/source/man/stackviz-export.rst: Specifies a :code:`.testrepository` to read subunit streams from. This
./requirements.txt:testrepository>=0.0.18
./stackviz/export.py: help="A directory containing a `.testrepository` to "
./stackviz/parser/tempest_subunit.py:from testrepository.repository.file import RepositoryFactory
./stackviz/parser/tempest_subunit.py:from testrepository.repository.file import RepositoryNotFound
./stackviz/parser/tempest_subunit.py: '.testrepository' folders to read
./test/unit/services/test-dataset.js: "path": "testrepository.subunit-0-raw.json",
./test/unit/services/test-dataset.js: "artifact_name": "testrepository.subunit"
./test/unit/services/test-dataset.js: "path": "testrepository.subunit-0-details.json",
./test/unit/services/test-dataset.js: "artifact_name": "testrepository.subunit"
./test/unit/services/test-dataset.js: "path": "testrepository.subunit-0-stats.json",
./test/unit/services/test-dataset.js: "artifact_name": "testrepository.subunit"
./test/unit/services/test-dataset.js: expect(groups).toContain('testrepository.subunit');
./test/unit/services/test-dataset.js: service.artifacts('testrepository.subunit').then(function(artifacts) {
./test/unit/services/test-dataset.js: httpBackend.whenGET('data/testrepository.subunit-0-raw.json').respond({
./test/unit/services/test-dataset.js: service.artifact('testrepository.subunit', 'subunit').then(function(resp) {
[master][centos@mkopec-devstack stackviz]$

Changed in stackviz:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stackviz (master)

Reviewed: https://review.opendev.org/c/openstack/stackviz/+/796488
Committed: https://opendev.org/openstack/stackviz/commit/19c30567542f3ccfa319d0c7b249397954bcfbcd
Submitter: "Zuul (22348)"
Branch: master

commit 19c30567542f3ccfa319d0c7b249397954bcfbcd
Author: lpiwowar <email address hidden>
Date: Tue Jun 15 16:24:02 2021 +0200

    Use stestr instead of testrepository

    This patch removes dependencies on testrepository as
    stackviz is using stestr instead.

    Closes-Bug: 1735667
    Change-Id: I1e1de567fae7a2f7985f51e35d71201be2ab787f

Changed in stackviz:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.